add a pip locking versions functionality for backend addon installation#291
add a pip locking versions functionality for backend addon installation#291ionlizarazu wants to merge 1 commit into
Conversation
| install: $(VENV_FOLDER) config ## Install Plone and dependencies | ||
|
|
||
| @uv pip compile pyproject.toml requirements-mxdev.txt -o ${LOCKFILE} | ||
| @uv pip install -r $(LOCKFILE) |
There was a problem hiding this comment.
This doesn't look like the right way to use a lock file to me:
- This Makefile target depends on $(VENV_FOLDER) which already installed packages without a lock file.
- Compiling the lock file at the same time that you install it defeats the purpose of using a lockfile (to avoid unexpected updates)
There was a problem hiding this comment.
Reading the uv docs "When using an output file, uv will consider the versions pinned in an existing output file. If a dependency is pinned it will not be upgraded on a subsequent compile run."
So, this should lock the versions installed during the first run, right?
There was a problem hiding this comment.
Reading the uv docs "When using an output file, uv will consider the versions pinned in an existing output file. If a dependency is pinned it will not be upgraded on a subsequent compile run."
So, this should lock the versions installed during the first run, right?
we are not using UV lock files, but pip lock files, anyway as far as we checked the docs, the behavior of the command is the same, the file is checked before writing to it.
Anyway we need that support also inside the Dockerfile, to build the image with the locked versions.
There was a problem hiding this comment.
Please talk to @ericof first and agree whether or not we can move toward using uv sync, so we don't have work happening in two different directions.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #