feat: generate GitLab CI/CD config using a subtemplate#243
Conversation
stevepiercy
left a comment
There was a problem hiding this comment.
The ci_gitlab/README.md needs some love. I think @ericof had an idea of how to generate all READMEs from boilerplate, but I'm not sure where that is at.
| - apk add --no-cache make bash python3 ncurses openssh-client-common git | ||
| script: | ||
| - cd backend | ||
| - make check |
There was a problem hiding this comment.
Where is the check-target in the Makefile? Do you mean make lint?
There was a problem hiding this comment.
yes, I meant make lint. I had an older version of cookieplone-templates in place where make check was the command, sorry about that :(
There was a problem hiding this comment.
You only change the - to a / in the Makefile. The Makefiles in project_settings and classic_project_settings are not identical, so this is not ok.
It might be best to have one Makefile for both (as a subtemplate?) and make some targets conditional and the separator also conditional.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
|
I have reworked this, reviewed and added tests. The only thing that I don't like is overwriting the @pbauer suggested a way to address it creating a subtemplate for Makefiles, but I haven't checked it yet. |
As an alternative to #239 in this PR we add the GitLab CI/CD config as a subtemplate