Skip to content

Handle external-state plugin errors with ErrorController#868

Open
KVSRoyal wants to merge 1 commit into
player-1-dot-zerofrom
external-action-error
Open

Handle external-state plugin errors with ErrorController#868
KVSRoyal wants to merge 1 commit into
player-1-dot-zerofrom
external-action-error

Conversation

@KVSRoyal
Copy link
Copy Markdown
Member

Now that ErrorController is available, we use that to handle errors from the external-state plugin instead of letting it fall through. See included docs updates for more details.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A. Part of 1.0

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Bundle Report

Changes will increase total bundle size by 375.17kB (7.83%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
plugins/asset-transform/core 7.91kB -3.34kB (-29.69%) ⬇️
plugins/external-state/core 426.16kB 378.51kB (794.3%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: plugins/asset-transform/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.legacy-esm.js -3.34kB 0 bytes -100.0%
view changes for bundle: plugins/external-state/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
ExternalStatePlugin.native.js 373.76kB 408.09kB 1088.77% ⚠️
cjs/index.cjs 1.62kB 6.78kB 31.46% ⚠️
index.legacy-esm.js 1.56kB 5.64kB 38.22% ⚠️
index.mjs 1.56kB 5.64kB 38.22% ⚠️

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (d09c972) to head (dbf4003).

Additional details and impacted files
@@           Coverage Diff            @@
##   player-1-dot-zero   #868   +/-   ##
========================================
========================================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KVSRoyal KVSRoyal marked this pull request as ready for review May 16, 2026 03:17
@KVSRoyal KVSRoyal requested review from a team as code owners May 16, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant