Skip to content

Moved tapAndAssertElementAppears to AssetUITestCase#867

Open
JunDangIntuit wants to merge 2 commits into
mainfrom
Move-tapAndAssertElementAppears-method-to-AssetUITestCase
Open

Moved tapAndAssertElementAppears to AssetUITestCase#867
JunDangIntuit wants to merge 2 commits into
mainfrom
Move-tapAndAssertElementAppears-method-to-AssetUITestCase

Conversation

@JunDangIntuit
Copy link
Copy Markdown
Contributor

tapAndAssertElementAppears solves a generic UI-test race (tap before async SwiftUI/JS binding wires up) — not something specific to managed-player tests. Keeping it private forces other UI tests to copy or reinvent it. Moving it to the shared AssetUITestCase (next to waitFor/waitAndTap/tap) gives every UI test one canonical, public helper with no extra imports.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

tapAndAssertElementAppears solves a generic UI-test race (tap before async SwiftUI/JS binding wires up) — not something specific to managed-player tests. Keeping it private forces other UI tests to copy or reinvent it. Moving it to the shared AssetUITestCase (next to waitFor/waitAndTap/tap) gives every UI test one canonical, public helper with no extra imports.
@JunDangIntuit JunDangIntuit requested a review from a team as a code owner May 15, 2026 19:14
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (23a98a4) to head (6d92826).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #867   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant