fix: Texture#lock allocates when mip level slot is missing#8695
Merged
mvaligursky merged 1 commit intomainfrom May 7, 2026
Merged
fix: Texture#lock allocates when mip level slot is missing#8695mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
Without options.levels, _clearLevels() only sets index 0 to null; higher mips are undefined. Treat falsy slots as empty so lock() returns a buffer. Fixes #8659
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the texture is created without
options.levels,_clearLevels()only initializes mip 0 ([null]for 2D). Higher mip indices areundefined, notnull, so the previous=== nullcheck skipped allocation andlock()returnedundefined(see #8659).Changes:
if (!levels[options.level])before allocating the typed array forTexture#lock.Fixes #8659