feat: Add Scene#gsplatCentersEnabled opt-out for gsplat CPU centers#8691
Merged
mvaligursky merged 1 commit intomainfrom May 6, 2026
Merged
feat: Add Scene#gsplatCentersEnabled opt-out for gsplat CPU centers#8691mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-out so loaded gsplat assets can omit the CPU-side centers buffer when only unified GPU sorting (or other paths that do not need it) is required, reducing memory for large SOG/PLY loads.
Changes:
Scene#gsplatCentersEnabled(defaulttrue) with JSDoc; each parser load snapshots the flag before its firstawaitand passesprepareCentersinto resources.GSplatResourceBase:_centersstorage withcentersaccessor, optionalprepareCentersin constructor, andhasCenters(non-null check without triggering container lazycenters).prepareGpuDatawhen centers are disabled at load.GSplatContainer: lazycentersallocation viasuper(..., { prepareCenters: false }).GSplatManager: when CPU sorting is active, omit placements without centers;_worldStateDirtyon renderer mode change; clearerwarnOncemessages.GSplatInstance: gate onhasCenters, matching warning style.Hidden API:
Scene#gsplatCentersEnabled—boolean, defaulttrue. Set tofalsebefore starting a gsplat asset load to omit centers data for that load (see JSDoc forGSPLAT_RENDERER_RASTER_CPU_SORTand timing).Impact