Merged
Conversation
v200390 & v200400 table data
1.34.0 merge dev
- Add FavRewardData (Ticker, Ratio, Min, Max) to StageSheet, replacing fixed ticker+amount fields - Add FavRewards list (5 entries × 4 fields) in CSV columns 53-72, before EntryCostItemId/Count - Add StageSimulator.GetFavWaveRewards() using WeightedSelector, mirroring GetWaveRewards() - Integrate FAV drops into HackAndSlash inner Execute loop (pre-determined, Wave 2 condition) - Integrate FAV drops into HackAndSlashSweep per play count - Add Execute_StageFavReward tests for both HackAndSlash and HackAndSlashSweep Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- StageSimulator now computes FAV rewards internally (wave 2) and exposes them via FungibleAssetRewards property, mirroring InfiniteTowerSimulator's pattern - GetReward battle-log event now carries both item and FAV rewards in a single event (consistent with infinite tower) - HackAndSlash reads FAV rewards from simulator.FungibleAssetRewards instead of computing them separately before simulation - Remove stage-number normalization (451-900 → 1-450) from StageRewardExpHelper.GetExp that is no longer needed Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove auto-clone logic from StageSheet, StageWaveSheet, CrystalStageBuffGachaSheet; add explicit CSV rows for stages 451-900 - Stages 451-900 clone stats from 1-450 with entry_cost_item_id=50000 - Add fav_drop_min/fav_drop_max columns to StageSheet (fields 73-74); entry cost shifts to fields 75-76 - StageSheet.Row exposes FavDropMin/FavDropMax properties - GetFavWaveRewards now draws from the FAV pool fav_drop_count times, merging amounts per ticker (same behavior as item drop pool) - Stages 451-900 configured with 5 FAV tickers (CRYSTAL + 4 RUNESTONE), fav_drop_min=max=5, each ticker min=max=1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- SweepRequiredCPSheet: RequiredCP int → long (current max ~1.5B, approaching int32 limit) - StakeRegularRewardSheet: RequiredGold ParseInt → ParseLong (field declared as long) - StakeAchievementRewardSheet: RequiredGold/RequiredBlockIndex ParseInt → ParseLong (fields declared as long) - EnhancementCostSheet: Cost ParseInt → ParseBigInteger (field declared as BigInteger) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add FAV rewards to stage drops via WeightedSelector
Add optional `tradable` CSV column to `StakeRegularFixedRewardSheet` so that fixed staking rewards can control item tradability, consistent with the existing behavior in `StakeRegularRewardSheet`. Omitting the column defaults to `true`, preserving backward compatibility with existing data. - `RewardInfo`: add `Tradable` field with XML doc; parse from optional `fields[2]` (default `true`); reflect in `Equals`/`GetHashCode` - `StakeRewardCalculator.CalculateFixedRewards`: branch on `reward.Tradable` to call `CreateTradableMaterial` or `CreateMaterial` accordingly - Add `V1WithTradable` test fixture and `SetToSheet_WithTradableColumn` test - Add XML doc comments to `StakeRewardCalculator` class and both methods Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add Tradable flag to StakeRegularFixedRewardSheet.RewardInfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.