auto update edge-tts by pladisdev · Pull Request #39 · pladisdev/chat-yapper

pladisdev · 2026-04-05T17:32:53Z

No description provided.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

…4b50-93c4-0e11b13594f4 Clarify error handler ordering is correct - no changes needed

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

…47b6-b204-5bf8892748d3 Extract magic numbers to named constants in audio playback code

…4606-8149-97ceaa22873d Use platform.system() instead of sys.platform for OS detection

Extract duplicated hex opacity calculation to utility function

Extract avatar active offset magic number into configurable setting

Fix audio reference cleanup on play() failure in popup mode

Fix race condition in popup avatar lifecycle

…into development

Copilot

Pull request overview

Updates dependencies and build/config behavior across the backend, frontend, and CI to address Edge TTS compatibility and release pipeline changes.

Changes:

Bump edge-tts version and add backend logic to retry synthesis by attempting a runtime edge-tts upgrade on certain 403 errors.
Frontend: fix Vite ESM __dirname handling and add a default / route redirect to /settings.
CI/Release: move Windows MSI build to WiX v5 and reduce Docker involvement in releases.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
requirements.txt	Bumps `edge-tts` pinned version.
frontend/vite.config.js	Defines `__dirname` for ESM-based Vite config path resolution.
frontend/src/app.jsx	Adds root route redirect to `/settings`.
frontend/package-lock.json	Updates lockfile entries from dependency refresh.
deployment/build_msi.py	Adjusts WiX extension detection to include global installs.
backend/modules/tts.py	Adds 403-triggered retry + runtime `edge-tts` upgrade attempt.
.github/workflows/build-and-release.yml	Updates WiX install to v5 and reduces Docker usage in release flow.

Files not reviewed (1)

frontend/package-lock.json: Language not supported

Comments suppressed due to low confidence (1)

deployment/build_msi.py:56

check_wix_extensions() now checks global extensions, but the auto-install path still runs wix extension add WixToolset.UI.wixext without --global (and without a version), which can diverge from the CI setup (--global WixToolset.UI.wixext/5.0.1). Align the install command with the expected scope/version so local builds match CI.

        # Check both local and global extensions
        result = subprocess.run("wix extension list", shell=True, capture_output=True, text=True)
        global_result = subprocess.run("wix extension list --global", shell=True, capture_output=True, text=True)
        
        if "WixToolset.UI.wixext" in result.stdout or "WixToolset.UI.wixext" in global_result.stdout:
            print("WiX UI extension found")
            return True
        else:
            print("\nWARNING: WiX UI extension not found!")
            print("Installing WixToolset.UI.wixext...")
            install_result = subprocess.run("wix extension add WixToolset.UI.wixext", 
                                          shell=True, capture_output=True, text=True)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-05T17:36:15Z

backend/modules/tts.py

 import uuid
 import time
+import sys
+import subprocess


subprocess is imported but not used in this module; please remove it to avoid lint/packaging noise.

Suggested change

import subprocess

Copilot · 2026-04-05T17:36:15Z

backend/modules/tts.py

+# Track edge-tts update attempts to avoid repeated updates
+_edge_tts_update_attempted = False
+
+async def try_update_edge_tts():
+    """Attempt to update edge-tts package when API compatibility issues occur"""
+    global _edge_tts_update_attempted
+
+    if _edge_tts_update_attempted:
+        logger.info("edge-tts update already attempted this session, skipping")
+        return False
+
+    _edge_tts_update_attempted = True
+    logger.info("Attempting to update edge-tts package to fix API compatibility...")
+
+    try:
+        # Run pip upgrade in subprocess
+        python_exe = sys.executable
+        result = await asyncio.create_subprocess_exec(
+            python_exe, "-m", "pip", "install", "--upgrade", "edge-tts",
+            stdout=asyncio.subprocess.PIPE,
+            stderr=asyncio.subprocess.PIPE
+        )
+        stdout, stderr = await result.communicate()
+
+        if result.returncode == 0:
+            logger.info(f"edge-tts successfully updated: {stdout.decode()}")
+
+            # Reload the edge_tts module
+            try:
+                import importlib
+                global edge_tts
+                if edge_tts:
+                    importlib.reload(edge_tts)
+                    logger.info("edge-tts module reloaded successfully")
+                else:
+                    import edge_tts as new_edge_tts
+                    edge_tts = new_edge_tts
+                    logger.info("edge-tts module imported successfully")
+                return True
+            except Exception as e:
+                logger.warning(f"edge-tts updated but module reload failed: {e}")
+                logger.info("Restart the application to use the updated edge-tts")
+                return False
+        else:
+            logger.error(f"edge-tts update failed: {stderr.decode()}")
+            return False
+    except Exception as e:
+        logger.error(f"Failed to update edge-tts: {e}")
+        return False


This introduces a runtime pip install --upgrade edge-tts inside the server process. That can break reproducible deployments (conflicts with the pinned edge-tts==... in requirements), fail in read-only/container environments, and expands the attack surface by fetching code at runtime. Consider removing the auto-upgrade and instead surface a clear error/instruction (or gate it behind an explicit admin setting/env var and pin to an expected version).

Suggested change

# Track edge-tts update attempts to avoid repeated updates

_edge_tts_update_attempted = False

async def try_update_edge_tts():

"""Attempt to update edge-tts package when API compatibility issues occur"""

global _edge_tts_update_attempted

if _edge_tts_update_attempted:

logger.info("edge-tts update already attempted this session, skipping")

return False

_edge_tts_update_attempted = True

logger.info("Attempting to update edge-tts package to fix API compatibility...")

try:

# Run pip upgrade in subprocess

python_exe = sys.executable

result = await asyncio.create_subprocess_exec(

python_exe, "-m", "pip", "install", "--upgrade", "edge-tts",

stdout=asyncio.subprocess.PIPE,

stderr=asyncio.subprocess.PIPE

)

stdout, stderr = await result.communicate()

if result.returncode == 0:

logger.info(f"edge-tts successfully updated: {stdout.decode()}")

# Reload the edge_tts module

try:

import importlib

global edge_tts

if edge_tts:

importlib.reload(edge_tts)

logger.info("edge-tts module reloaded successfully")

else:

import edge_tts as new_edge_tts

edge_tts = new_edge_tts

logger.info("edge-tts module imported successfully")

return True

except Exception as e:

logger.warning(f"edge-tts updated but module reload failed: {e}")

logger.info("Restart the application to use the updated edge-tts")

return False

else:

logger.error(f"edge-tts update failed: {stderr.decode()}")

return False

except Exception as e:

logger.error(f"Failed to update edge-tts: {e}")

return False

# Track edge-tts update attempts to avoid repeated update instructions

_edge_tts_update_attempted = False

async def try_update_edge_tts():

"""Log a one-time instruction to update edge-tts outside the running process."""

global _edge_tts_update_attempted

if _edge_tts_update_attempted:

logger.info("edge-tts update already flagged this session, skipping")

return False

_edge_tts_update_attempted = True

logger.error(

"edge-tts appears incompatible, but automatic runtime upgrades are disabled. "

"Please update the pinned 'edge-tts' dependency through your normal build/deploy "

"process and restart the application."

)

return False

Copilot · 2026-04-05T17:36:16Z

backend/modules/tts.py

+
+async def try_update_edge_tts():
+    """Attempt to update edge-tts package when API compatibility issues occur"""
+    global _edge_tts_update_attempted
+
+    if _edge_tts_update_attempted:
+        logger.info("edge-tts update already attempted this session, skipping")
+        return False
+
+    _edge_tts_update_attempted = True
+    logger.info("Attempting to update edge-tts package to fix API compatibility...")
+


The _edge_tts_update_attempted guard is a shared global without synchronization. With concurrent synth requests, multiple tasks can still race into try_update_edge_tts() and run upgrades simultaneously. Consider guarding with an asyncio.Lock (or similar) to ensure only one update attempt runs at a time.

Suggested change

async def try_update_edge_tts():

"""Attempt to update edge-tts package when API compatibility issues occur"""

global _edge_tts_update_attempted

if _edge_tts_update_attempted:

logger.info("edge-tts update already attempted this session, skipping")

return False

_edge_tts_update_attempted = True

logger.info("Attempting to update edge-tts package to fix API compatibility...")

_edge_tts_update_lock = asyncio.Lock()

async def try_update_edge_tts():

"""Attempt to update edge-tts package when API compatibility issues occur"""

global _edge_tts_update_attempted

async with _edge_tts_update_lock:

if _edge_tts_update_attempted:

logger.info("edge-tts update already attempted this session, skipping")

return False

_edge_tts_update_attempted = True

logger.info("Attempting to update edge-tts package to fix API compatibility...")

Copilot · 2026-04-05T17:36:16Z

backend/modules/tts.py

+        # Helper function to attempt synthesis with retry logic
+        async def attempt_synthesis(voice_id: str, retry_on_403: bool = True):
+            try:
+                communicate = edge_tts.Communicate(job.text, voice_id)
+                await communicate.save(outpath)
+                return True
+            except Exception as e:
+                # Check if it's a 403 error (API compatibility issue)
+                error_str = str(e)
+                if "403" in error_str and "Invalid response status" in error_str and retry_on_403:
+                    logger.warning(f"Edge TTS returned 403 error - API may need updating")
+                    # Attempt to update edge-tts
+                    if await try_update_edge_tts():
+                        logger.info("Retrying synthesis after edge-tts update...")
+                        # Retry once after update (without further retries)
+                        return await attempt_synthesis(voice_id, retry_on_403=False)
+                    else:
+                        logger.error("edge-tts update failed or requires restart. Please restart the application.")
+                raise


New 403-detection + auto-update retry logic isn’t covered by existing unit tests. Add a unit test that mocks edge_tts.Communicate.save to raise the 403 error once, asserts try_update_edge_tts() is invoked at most once per session, and verifies synthesis is retried (or that a clear error is surfaced when update fails).

Copilot · 2026-04-05T17:36:16Z

.github/workflows/build-and-release.yml

+    # Commented out to speed up CI - Docker build takes too long
+    # - name: Build and push Docker image
+    #   uses: docker/build-push-action@v5
+    #   with:
+    #     context: .
+    #     file: ./docker/Dockerfile
+    #     push: true
+    #     tags: ${{ steps.meta.outputs.tags }}
+    #     labels: ${{ steps.meta.outputs.labels }}
+    #     platforms: linux/amd64,linux/arm64
+    #     cache-from: type=gha
+    #     cache-to: type=gha,mode=max
+    #     build-args: |
+    #       APP_VERSION=${{ steps.docker_version.outputs.app_version }}


The Docker build step is commented out, but the job still logs into GHCR, computes metadata, and later posts a PR comment claiming an image was built/published. Either disable the whole docker-build job, or gate the downstream steps/comments/artifacts on actually building/pushing the image to avoid misleading CI output.

Copilot · 2026-04-05T17:36:16Z

.github/workflows/build-and-release.yml

@@ -128,10 +128,9 @@ jobs:
        wix --version

        Write-Host "Installing WiX UI extension globally..."
-        wix extension add --global WixToolset.UI.wixext
+        wix extension add --global WixToolset.UI.wixext/5.0.1

        Write-Host "Verifying UI extension..."
-        wix extension list
        wix extension list --global



PR title indicates an edge-tts update, but this workflow change also upgrades WiX to v5 and changes release/build dependencies (including de-emphasizing Docker). If these are intentional, consider splitting them into a separate PR or updating the PR title/description so reviewers can assess CI/release changes explicitly.

github-actions · 2026-04-05T17:37:42Z

✅ Windows Build Successful

Executable: ChatYapper.exe (67.00 MB)
MSI Installer: ChatYapper-1.3.1.msi (66.32 MB)
App Version: 1.3.1
Build ID: build-v1.3.1-2026.04.05-5b4c76f
Commit: 5b4c76f

Build Status

✅ Windows executable & MSI installer
🔄 Linux build (check separate job)
🔄 Docker image (check separate job)

Download the artifacts from the workflow run to test before merging.

Once merged to main, an official release will be created automatically with tag v1.3.1.

github-actions · 2026-04-05T17:38:10Z

🐳 Docker Image Built Successfully

Image: ghcr.io/pladisdev/chat-yapper:pr-5b4c76f
Tag: pr-5b4c76f

Test this PR with Docker:

docker pull ghcr.io/pladisdev/chat-yapper:pr-5b4c76f

docker run -d \
  --name chat-yapper-pr \
  -p 8069:8008 \
  -e TWITCH_CLIENT_ID=your_id \
  -e TWITCH_CLIENT_SECRET=your_secret \
  ghcr.io/pladisdev/chat-yapper:pr-5b4c76f

Access at: http://localhost:8069

The Docker image will be published to the GitHub Container Registry when merged to main.

pladisdev and others added 30 commits November 2, 2025 09:42

pop up mode and chat buble toggle

56e44f8

potential audio fix

82db2b0

linux sh and better docker support

579683d

fixed linux build?

fad6d1a

linux fix part 2

a12de82

docker fix part 1

5d79afe

Initial plan

0f3af89

Initial plan

d5d90f6

Initial plan

cbf5fcd

Initial plan

5a5d1d5

Initial plan

207ba9b

Initial plan

76b9912

Initial plan

366b640

Update frontend/src/pages/YappersPage.jsx

ebc7bb7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

be9a086

Update frontend/src/pages/YappersPage.jsx

3fc9146

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Replace sys.platform with platform.system() for OS detection

914b789

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix race condition in popup avatar lifecycle

938886f

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Extract magic numbers to named constants for better readability

7737a2f

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Extract magic number -2.5px into avatarActiveOffset setting

3ea0d45

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix audio cleanup in popup mode when play() fails

ee4de2a

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Merge pull request #17 from pladisdev/copilot/sub-pr-8-bf786502-ac5d-…

3ae0527

…4b50-93c4-0e11b13594f4 Clarify error handler ordering is correct - no changes needed

Extract hex opacity calculation to utility function

25dc303

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix audio error handlers to clean up tracking references

730dc88

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Merge pull request #16 from pladisdev/copilot/sub-pr-8-4be2dd0e-06ec-…

bb266bd

…47b6-b204-5bf8892748d3 Extract magic numbers to named constants in audio playback code

Merge pull request #15 from pladisdev/copilot/sub-pr-8-9e407134-0238-…

7d70a13

…4606-8149-97ceaa22873d Use platform.system() instead of sys.platform for OS detection

Merge pull request #14 from pladisdev/copilot/sub-pr-8-please-work

d1f450d

Extract duplicated hex opacity calculation to utility function

Merge pull request #13 from pladisdev/copilot/sub-pr-8-one-more-time

5436727

Extract avatar active offset magic number into configurable setting

Merge pull request #12 from pladisdev/copilot/sub-pr-8-yet-again

d8c850e

Fix audio reference cleanup on play() failure in popup mode

Merge pull request #11 from pladisdev/copilot/sub-pr-8-another-one

1405787

Fix race condition in popup avatar lifecycle

pladisdev and others added 24 commits November 25, 2025 21:50

twitch fix, better fonts, cleanup

365ef8e

Merge branch 'main' into development

61d9dcf

fixed imports

046c52f

fixed things

7b33d13

Merge branch 'main' into development

638fb4e

undefined fix

59a7722

twitch test fix

4a09f0b

another mock fix

99b9642

another fix for twitch creds tests

15efb3c

better logging

6ca3832

twitch fixes?

08355e7

another twitch fix

0d7bb86

Merge branch 'main' into development

484caaf

fix twitch io 3.x

a45dcfc

Merge branch 'development' of https://github.com/pladisdev/chat-yapper …

478e8ea

…into development

fix pipelines for python to use 3.10

6ad992d

Merge branch 'main' into development

2fcaa47

attempt to fix edge tts

4e39aa1

fixed build and release

01b85b8

annother wix fix

7a1ee84

global wix fix

8589ceb

Merge branch 'main' into development

0f9441b

update to edge-tts

ca487ed

Merge branch 'development' of https://github.com/pladisdev/chat-yapper …

a7b0ddf

…into development

Copilot AI review requested due to automatic review settings April 5, 2026 17:33

Copilot started reviewing on behalf of pladisdev April 5, 2026 17:33 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

pladisdev merged commit 2f15868 into main Apr 5, 2026
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

auto update edge-tts#39

auto update edge-tts#39
pladisdev merged 82 commits intomainfrom
development

pladisdev commented Apr 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 5, 2026

Uh oh!

Copilot AI Apr 5, 2026

Uh oh!

Copilot AI Apr 5, 2026

Uh oh!

Copilot AI Apr 5, 2026

Uh oh!

Copilot AI Apr 5, 2026

Uh oh!

Copilot AI Apr 5, 2026

Uh oh!

github-actions bot commented Apr 5, 2026

Uh oh!

github-actions bot commented Apr 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

pladisdev commented Apr 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 5, 2026

✅ Windows Build Successful

Build Status

Uh oh!

github-actions bot commented Apr 5, 2026

🐳 Docker Image Built Successfully

Test this PR with Docker:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants