Skip to content

Add “Wikidata QuickStatements Export” plugin (import/export) — OJS 3.5 (v1.0.0-3.5)#415

Closed
saddamalsalfi wants to merge 13 commits intopkp:mainfrom
saddamalsalfi:add-quickstatements-export-1.0.0-3.5
Closed

Add “Wikidata QuickStatements Export” plugin (import/export) — OJS 3.5 (v1.0.0-3.5)#415
saddamalsalfi wants to merge 13 commits intopkp:mainfrom
saddamalsalfi:add-quickstatements-export-1.0.0-3.5

Conversation

@saddamalsalfi
Copy link
Copy Markdown

@saddamalsalfi saddamalsalfi commented Sep 15, 2025

Summary:
This PR adds a new entry to plugins.xml for the Wikidata QuickStatements Export plugin (category: importexport, product/slug: quickstatements). The plugin exports OJS issues/articles metadata to Wikidata via QuickStatements, with optional auto-submit and DOI de-duplication through the Wikidata API. Includes i18n strings (EN/AR).

Repository:
Homepage: https://github.com/saddamalsalfi/ojs-quickstatements-export
Release package:
URL: https://github.com/saddamalsalfi/ojs-quickstatements-export/releases/download/v1.0.0/quickstatements-v1.0.0-3.5.tar.gz

MD5 (matches plugins.xml): e7a6efbbe1a4b4a7d34c26a74e5b449e
Compatibility
OJS: ~ 3.4.0.9, 3.5.0.0

License & contact
License: GPL-3.0-or-later

Authors: Queen Arwa University – Journal Team; Saddam Hussein Al-Slfi
Contact: saddamalsalfi@qau.edu.ye

@asmecher
Copy link
Copy Markdown
Member

@saddamalsalfi, sorry for the delay on this one!

@bozana, could you review this one (or delegate)? Thanks!

@bozana bozana self-requested a review November 19, 2025 13:20
@saddamalsalfi saddamalsalfi marked this pull request as draft March 4, 2026 22:27
@saddamalsalfi saddamalsalfi marked this pull request as ready for review March 4, 2026 22:27
Copilot AI review requested due to automatic review settings March 4, 2026 22:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new plugin entry for the Wikidata QuickStatements Export plugin to plugins.xml. The plugin, developed by Queen Arwa University, exports OJS issue/article metadata to Wikidata via QuickStatements, supporting optional auto-submit and DOI de-duplication. However, the diff also unexpectedly removes the entire Publication Facts Label (pflPlugin) entry, which is a serious unintended side-effect not mentioned in the PR description.

Changes:

  • Adds a new <plugin> entry for quickstatements (category: importexport) in plugins.xml
  • Removes the complete pflPlugin (Publication Facts Label) entry from plugins.xml — unintended

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins.xml
Comment thread plugins.xml Outdated
Comment thread plugins.xml Outdated
Comment thread plugins.xml Outdated
Comment thread plugins.xml
saddamalsalfi and others added 4 commits March 5, 2026 01:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Author

@saddamalsalfi saddamalsalfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch has been corrected

@asmecher
Copy link
Copy Markdown
Member

asmecher commented Mar 5, 2026

@saddamalsalfi, the branch cannot be rebased or merged due to conflicts. Please rebase the PR (and human-verify anything produced by an LLM), and then we'll take a look.

@bozana
Copy link
Copy Markdown

bozana commented Mar 12, 2026

maybe also a note here: I took a first look at the plugin code long time ago, and because the plugin does not use the standard PKP code design and structure it was very difficult to review it. I do not even know the details I should provide the review comments for. If this would be a PKP developer I would have lots to comment, and lots of changes would needed to be done. In similar cases in the future, I could try to concentrate only on the security issues, but even this will not be easy if the code does not apply to our standards...

@saddamalsalfi saddamalsalfi deleted the add-quickstatements-export-1.0.0-3.5 branch March 13, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants