Conversation
…where run_tts has been invoked but the BotStartedSpeakingFrame has not yet been received.
filipi87
force-pushed
the
filipi/tts_improvements_remove_reset
branch
from
8c16cfa to
c4466ba
Compare
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
markbackman
approved these changes
Mar 27, 2026
Contributor
markbackman
left a comment
markbackman
left a comment
There was a problem hiding this comment.
Change looks good.
I tested the services modified and all sound good.
I noticed issues with word timestamp / audio alignment for Inworld and Rime. I think we can follow up on those separately as they may be service related.
Nice cleanup! 👏
Contributor
Author
|
Hi @markbackman, yes, I had noticed that for I will take a look on what is happening for Rime. Thank you for testing this. 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Reset"and"TTSStoppedFrame"string sentinels fromadd_word_timestampsadd_word_timestamps([("TTSStoppedFrame", 0), ("Reset", 0)], ctx_id)now callappend_to_audio_context(ctx_id, TTSStoppedFrame(...))directly, and reset logic is handled uniformly at the end of_handle_audio_contextappend_to_audio_contextsignature broadened to acceptFrame | _WordTimestampEntry | None, andremove_audio_contextnow routes through it for consistencyon_audio_context_interruptedandon_audio_context_completedoverrides across TTS services now callsuper(), ensuring base class lifecycle hooks are consistently invokedInterruptibleTTSServicewhere, ifrun_ttshad been invoked butBotStartedSpeakingFramehad not yet been received, a user interruption could allow stale audio to leak through.