Open
Conversation
aconchillo
added a commit
that referenced
this pull request
Mar 24, 2026
filipi87
approved these changes
Mar 25, 2026
Contributor
filipi87
left a comment
filipi87
left a comment
There was a problem hiding this comment.
Makes sense. The tests are failing, could it be related to the changes here ?
LGTM!
Enable direct mode on FrameFilter, IdentityFilter, and NullFilter so they can bypass the async queue and process frames synchronously for lower latency. Also pass **kwargs through to parent in FrameFilter.
aconchillo
force-pushed
the
aleix/enable-direct-mode-filters
branch
from
a55d4b0 to
ac5810b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FrameFilter,IdentityFilter, andNullFilterso they bypass the async queue and process frames synchronously, reducing latency for simple pass-through/block operations**kwargsto parentFrameProcessorinFrameFilterfor consistency with the other filtersTesting
uv run pytest tests/— verify no regressions in existing filter tests🤖 Generated with Claude Code