Skip to content

Add PrivacyInfo.xcprivacy#325

Merged
jparise merged 2 commits into
pinterest:masterfrom
garricn:add-xcprivacy
Apr 24, 2024
Merged

Add PrivacyInfo.xcprivacy#325
jparise merged 2 commits into
pinterest:masterfrom
garricn:add-xcprivacy

Conversation

@garricn
Copy link
Copy Markdown
Contributor

@garricn garricn commented Mar 21, 2024

Addresses #324.

See Describing use of required reason API for more information.

Required Reason API Used Used in File
NSFileModificationDate PINCache/Source/PINDiskCache.m
NSFileModificationDate PINCache/Tests/PINCacheTests.m
NSURLContentModificationDateKey PINCache/Source/PINDiskCache.m
NSURLCreationDateKey PINCache/Source/PINDiskCache.m

Comment thread PrivacyInfo.xcprivacy Outdated
@hotngui
Copy link
Copy Markdown

hotngui commented Apr 1, 2024

The PrivacyInfo.xcprivacy file also needs to be added to the Package.swift file as a resource to by copied/processed.

@EFFYLYX
Copy link
Copy Markdown

EFFYLYX commented Apr 15, 2024

When would you like to merge this PR?

@garricn
Copy link
Copy Markdown
Contributor Author

garricn commented Apr 17, 2024

When would you like to merge this PR?

Hi @EFFYLYX. Thank you for replying. It would be great if this PR can merge now. Are you able to merge it?

@farzadshbfn
Copy link
Copy Markdown

@tinder-owenthomas any chance of merging this PR soon? we're approaching the deadline and it's good to give teams lead-time on updating their frameworks'.

@jparise jparise merged commit f856226 into pinterest:master Apr 24, 2024
@jparise
Copy link
Copy Markdown
Collaborator

jparise commented Apr 24, 2024

This change looks reasonable to me, so I'll help move things along by merging this. That will also give time for folks to adopt this change and provide feedback on anything that might need to be adjusted.

@gazadge
Copy link
Copy Markdown

gazadge commented Apr 29, 2024

Hey @jparise,
I added a new PR related to this issue for including the .xcprivacy file as resource when installing PINCache via Cocoapods. When you get a chance can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants