test: fix CheckpointReactor rollback assertions for threadId#242
test: fix CheckpointReactor rollback assertions for threadId#242dl-alexandre wants to merge 1 commit intopingdotgg:codething/648ca884-cursorfrom
Conversation
|
@dl-alexandre is attempting to deploy a commit to the Ping Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes the failing CI assertions in CheckpointReactor.test.ts for PR #178.
The rollback call payload now includes threadId; this updates expectations to match the current provider contract.
Validated locally:
Note
Fix CheckpointReactor tests to assert
provider.rollbackConversationreceivesthreadId: ThreadId.makeUnsafe("thread-1")andnumTurns: 1in CheckpointReactor.test.tsUpdate three assertions to include
threadIdalongsidenumTurnswhen verifyingprovider.rollbackConversationcalls in CheckpointReactor.test.ts.📍Where to Start
Start with the modified assertions around
provider.rollbackConversationin CheckpointReactor.test.ts.Macroscope summarized d273ce7.