Implement Liquid Glass Design#201
Open
knownassurajit wants to merge 12 commits intopilotmoon:masterfrom
Open
Conversation
This commit implements Apple's liquid glass design system by injecting a translucent NSVisualEffectView into the content view of all application windows (PrefsWindow, WelcomeWindow, TestWindow, DebugWindow). The windows are configured to have a transparent title bar and a full-size content view, which creates the desired glassmorphism/frosted effect under the window background. Changes: - PrefsWindowController.m: Add NSVisualEffectView in windowDidLoad. - WelcomeWindowController.m: Add NSVisualEffectView in windowDidLoad. - TestWindowController.m: Add NSVisualEffectView in windowDidLoad. - DebugWindowController.m: Add NSVisualEffectView in windowDidLoad.
Inlined the tileColor and tileRect logic directly into the nested loops within the testImage method of TestWindowController.m. This avoids approximately 131,072 block invocations in a tight loop, reducing CPU overhead for test image generation.
- Implemented comprehensive unit tests for Logger class in LoggerTests.m. - Added tests for initialization, normal/special logging, enabled/disabled state, bounding logic, and notifications. - Modified Logger.m to handle nil message input gracefully in logMessage:special: to prevent potential crashes when creating dictionary literals. - Verified test logic and implementation against Logger's behavior.
- Reverted incorrect changes to `StatusItemController.m` that modified application logic. - Updated `StatusItemControllerTests.m` to properly test the existing `attachMenu:` logic (which relies on `theMenu` and its delegate) and `openMenu` (which sets and unsets `statusItem.menu` to workaround an AppKit issue). - Verified that temporary ruby scripts are omitted from the patch. - Ensures the Xcode project test target (`ScrollReverserTests`) correctly includes `StatusItemControllerTests.m`.
…571387 🧪 Add StatusItemController Tests
…60017328174254 Implement liquid glass design system across all windows
…553514919723121199 ⚡ Optimize test image generation by inlining block calls
…tests-17420375822040665972 🧪 Add unit tests for Logger class and improve nil input handling
Co-authored-by: knownassurajit <34816337+knownassurajit@users.noreply.github.com>
…e14782e2 Apply Liquid Glass Design
In macOS 15, `[NSEvent eventWithCGEvent:]` throws an exception when called with `kCGEventTapDisabledByTimeout` or `kCGEventTapDisabledByUserInput` events. This causes the callback to fail before the tap can be re-enabled. Handling these events explicitly at the start of `_callback` fixes the issue. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This commit secures the Sparkle update mechanism by: 1. Prioritizing official Pilotmoon URLs for Production and Beta builds, ignoring any user-specified overrides in these environments. 2. For other builds (e.g., Development), validating that any provided override URL uses the HTTPS protocol. 3. Providing a safe fallback to `https://localhost/` if no valid URL is determined. This prevents potential man-in-the-middle (MITM) attacks and malicious updates via local preference tampering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.