Skip to content

Fix: double-slash path routing bug #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhii734 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: double-slash path routing bug #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/layer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ function Layer (path, options, fn) {
this.params = undefined
this.path = undefined
this.slash = path === '/' && opts.end === false
// Track if path is multiple slashes (like //) which needs special handling
this.multiSlash = /^\/+$/.test(path) && opts.end === false

function matcher (_path) {
if (_path instanceof RegExp) {
Expand Down Expand Up @@ -186,6 +188,14 @@ Layer.prototype.match = function match (path) {
return true
}

// For paths with multiple slashes (like //), match any path that's longer
// This is similar to '/' but excludes exact match
if (this.multiSlash && path.length > 1) {
this.params = {}
this.path = ''
return true
}

let i = 0
while (!match && i < this.matchers.length) {
// match the path
Expand Down Expand Up @@ -241,6 +251,12 @@ function loosen (path) {
return path
}

// Don't loosen paths that are only slashes (//, ///, etc.)
// These would become empty strings which matches everything
if (/^\/+$/.test(path)) {
return path
}

return Array.isArray(path)
? path.map(function (p) { return loosen(p) })
: String(path).replace(TRAILING_SLASH_REGEXP, '')
Expand Down