Skip to content

fix: prevent filter row overlap #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecarreras merged 1 commit into from
May 25, 2026
Merged

fix: prevent filter row overlap #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions dashboard/src/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ function Filters({ filters, actorOptions, onChange }: { filters: JobFilters; act
<ChevronDown className="h-4 w-4 text-muted" aria-hidden />
</summary>
<form
className="grid gap-3 border-t border-border bg-white p-3 md:grid-cols-3 xl:grid-cols-7"
className="grid gap-3 border-t border-border bg-white p-3 md:grid-cols-3 xl:grid-cols-8"
onSubmit={(event) => {
event.preventDefault();
onChange(draft);
Expand All @@ -778,7 +778,7 @@ function Filters({ filters, actorOptions, onChange }: { filters: JobFilters; act
<Field label="Action">
<input className="control" value={draft.action} placeholder="reply_comment" onChange={(event) => setDraft({ ...draft, action: event.target.value })} />
</Field>
<Field label="Actor">
<Field label="Actor" className="xl:col-span-2">
<ActorFilter value={draft.actor} options={actorOptions} onChange={(actor) => setDraft({ ...draft, actor })} />
</Field>
<Field label="Intent">
Expand Down Expand Up @@ -806,7 +806,7 @@ function ActorFilter({ value, options, onChange }: { value: string; options: Job
const selected = options.find((actor) => actor.login.toLowerCase() === normalizedValue);

return (
<div className="relative">
<div className="relative min-w-0">
<div className="control flex items-center gap-2 px-2">
{selected ? (
<img className="h-5 w-5 shrink-0 rounded-full bg-slate-100" src={safeExternalUrl(selected.avatar_url ?? "")} alt={`${selected.login} avatar`} referrerPolicy="no-referrer" />
Expand Down Expand Up @@ -858,9 +858,9 @@ function ActorFilter({ value, options, onChange }: { value: string; options: Job
);
}

function Field({ label, children }: { label: string; children: React.ReactNode }) {
function Field({ label, children, className }: { label: string; children: React.ReactNode; className?: string }) {
return (
<label className="grid gap-1 text-xs font-semibold text-muted">
<label className={cn("grid min-w-0 gap-1 text-xs font-semibold text-muted", className)}>
{label}
{children}
</label>
Expand Down
Binary file added docs/screenshots/issue-41/filters-desktop.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/screenshots/issue-41/filters-mobile.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions ...dashboard_static/assets/index-C25QDM5A.js → ...dashboard_static/assets/index-CwTu66TQ.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...ashboard_static/assets/index-CMqlfGS7.css → ...ashboard_static/assets/index-O_wrzEHH.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/github_agent_bridge/dashboard_static/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>GitHub Agent Bridge Dashboard</title>
<script type="module" crossorigin src="/assets/index-C25QDM5A.js"></script>
<script type="module" crossorigin src="/assets/index-CwTu66TQ.js"></script>
<link rel="modulepreload" crossorigin href="/assets/charts-DRWoArYU.js">
<link rel="stylesheet" crossorigin href="/assets/index-CMqlfGS7.css">
<link rel="stylesheet" crossorigin href="/assets/index-O_wrzEHH.css">
</head>
<body>
<div id="root"></div>
Expand Down
Loading