Skip to content

fix(categorize): unset margin for p in case of editor two lines PD-5669 #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arimieandreea wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(categorize): unset margin for p in case of editor two lines PD-5669 #2964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c774c5
fix(categorize): unset margin for p in case of editor two lines PD-5669
arimieandreea Mar 19, 2026
9e2fe48
fix(categorize): set back needed props PD-5669
arimieandreea Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/categorize/configure/src/design/categories/choice-preview.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ const DeleteIconButton = styled(IconButton)({
color: `${color.tertiary()} !important`,
});

const StyledDraggableChoice = styled(DraggableChoice)({
'& > p': {
margin: '0px !important',
},
});

export class ChoicePreview extends React.Component {
static propTypes = {
alternateResponseIndex: PropTypes.number,
Expand Down Expand Up @@ -50,7 +56,7 @@ export class ChoicePreview extends React.Component {
return (
<ChoicePreviewContainer>
{choice ? (
<DraggableChoice
<StyledDraggableChoice
alternateResponseIndex={alternateResponseIndex}
category={category}
choice={choice}
Expand All @@ -61,7 +67,7 @@ export class ChoicePreview extends React.Component {
categoryId={categoryId}
>
<HtmlAndMath html={choice?.content} />
</DraggableChoice>
</StyledDraggableChoice>
) : null}
<DeleteIconButton aria-label="delete" onClick={this.delete} size="large">
<RemoveCircleOutlineIcon />
Expand Down
3 changes: 3 additions & 0 deletions packages/categorize/src/categorize/choice.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ const StyledCardContent = styled(CardContent)(({ theme }) => ({
},
borderRadius: '4px',
border: '1px solid',
'& p': {
margin: '0px',
},
}));

export class Layout extends React.Component {
Expand Down
Loading