Fix 404 on bookmarked URLs with query strings#125
Open
fheinent wants to merge 1 commit into
Open
Conversation
`DashboardHandler.do_GET` matched `self.path` against the literal strings `/`, `/index.html`, and `/api/data`. `self.path` includes the query string, so any URL like `/?range=all` (the format the dashboard itself writes via `history.replaceState` for bookmarkable range/model filters) fell through to the 404 branch on hard-refresh or bookmark navigation. Routes don't depend on query parameters here, so split the path component with `urlparse(self.path).path` before matching. Apply the same in `do_POST` for symmetry. No new dependency — `urllib.parse` is stdlib. Smoke-tested locally: - GET / -> 200 (was 200) - GET /?range=all -> 200 (was 404) - GET /api/data -> 200 (was 200) - GET /api/data?x=1 -> 200 (was 404) - GET /nonexistent -> 404 (was 404)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DashboardHandler.do_GETmatchesself.pathagainst literal strings (/,/index.html,/api/data).self.pathincludes the query string, so URLs like/?range=all— the format the dashboard itself writes viahistory.replaceStatefor bookmarkable range/model filters — fall through to the 404 branch on hard-refresh or bookmark navigation.Repro
Fix
Split off the query string with
urlparse(self.path).pathbefore matching. Apply in bothdo_GETanddo_POST. No new dependency —urllib.parseis stdlib.Test plan (smoke-tested locally)
GET /GET /?range=allGET /?range=7dGET /api/dataGET /api/data?x=1GET /nonexistent