fix: replace stale cutoff with start/end in hourly filter#122
Open
SamzxSong wants to merge 1 commit into
Open
Conversation
The hourly filter in applyFilter() referenced an undefined `cutoff` variable, throwing ReferenceError and preventing every chart, total, and table on the dashboard from rendering. `cutoff` was leftover from before phuryn#43 introduced start/end date-range bounds; phuryn#72 (hourly activity chart) was written against the older single-cutoff pattern and merged without the rename. Mirror the daily filter (line 661) so hourly rows are gated by both start and end. Add a regression test that fails if the stale `cutoff` reference returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyFilter()indashboard.pyreferenced an undefinedcutoffvariable when buildinghourlySrc, throwingReferenceErrorand preventing every chart, total, and table on the dashboard from rendering.cutoffwas leftover from before #43 introducedstart/enddate-range bounds; #72 (hourly activity chart) was written against the older single-cutoff pattern and merged without the rename.Change
startandend:test_hourly_filter_uses_start_end_not_cutoff) that fails if the stale name returns.Test plan
python3 -m unittest tests.test_dashboard— all 24 tests passpython3 cli.py dashboardand reload the page — Daily Token Usage, Average Hourly Distribution, By Model, Top Projects by Tokens, and Cost by Model all render