feat(CLI): Add macOS binary signing using Apple Distribution certificate [STRINGS-1575]#829
feat(CLI): Add macOS binary signing using Apple Distribution certificate [STRINGS-1575]#829Efe Bikmaz (bikmazefe) wants to merge 3 commits intomainfrom
Conversation
Efe Bikmaz (bikmazefe)
requested review from
jablan and
Sönke Behrendt (theSoenke)
| echo "$CERTIFICATE_BASE64" | base64 --decode -o "$CERTIFICATE_PATH" | ||
|
|
||
| # Create temporary keychain | ||
| security create-keychain -p "$KEYCHAIN_PASSWORD" "$KEYCHAIN_PATH" |
There was a problem hiding this comment.
Do you need to run this inside a MacOS container to have the commands available?
There was a problem hiding this comment.
Very good and important point 😬 I assumed we were already doing it but confused it with the IOS SDK workflow.
There was a problem hiding this comment.
I'll also need to fix the dist directory though, as we're signing them in a separate action now.
|
Efe Bikmaz (@bikmazefe) is there a way to try this out before merging? |
jablan Yeah that's what I'm trying to find out currently. It seems like we can use the |
jablan
left a comment
jablan
left a comment
There was a problem hiding this comment.
I'm up for trying it out in the repo, I guess the worst case it will fail so you'd have another fix(CLI) PR, or two.
|
Closing in favor of #1002 |
3 participants
Add macOS binary signing using Apple Distribution certificate.