Skip to content

Skip "might not exist" report for string types with integer offsets in union decomposition check #5705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phpstan-bot wants to merge 1 commit into from
+27 −0
Closed

Skip "might not exist" report for string types with integer offsets in union decomposition check #5705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Rules/Arrays/NonexistentOffsetInArrayDimFetchCheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@
if (
$innerType->hasOffsetValueType($innerDimType)->no()
) {
if ($innerType->isString()->yes() && $innerDimType->isInteger()->yes()) {

Check warning on line 129 in src/Rules/Arrays/NonexistentOffsetInArrayDimFetchCheck.php

View workflow job for this annotation

GitHub Actions / Mutation Testing (8.4, ubuntu-latest) 

Escaped Mutant for Mutator "PHPStan\Infection\TrinaryLogicMutator":

@@ @@
 					if (
 						$innerType->hasOffsetValueType($innerDimType)->no()
 					) {
-						if ($innerType->isString()->yes() && $innerDimType->isInteger()->yes()) {
+						if ($innerType->isString()->yes() && !$innerDimType->isInteger()->no()) {
 							continue;
 						}
 						$report = true;

Check warning on line 129 in src/Rules/Arrays/NonexistentOffsetInArrayDimFetchCheck.php

View workflow job for this annotation

GitHub Actions / Mutation Testing (8.4, ubuntu-latest) 

Escaped Mutant for Mutator "PHPStan\Infection\TrinaryLogicMutator":

@@ @@
 					if (
 						$innerType->hasOffsetValueType($innerDimType)->no()
 					) {
-						if ($innerType->isString()->yes() && $innerDimType->isInteger()->yes()) {
+						if (!$innerType->isString()->no() && $innerDimType->isInteger()->yes()) {
 							continue;
 						}
 						$report = true;

Check warning on line 129 in src/Rules/Arrays/NonexistentOffsetInArrayDimFetchCheck.php

View workflow job for this annotation

GitHub Actions / Mutation Testing (8.3, ubuntu-latest) 

Escaped Mutant for Mutator "PHPStan\Infection\TrinaryLogicMutator":

@@ @@
 					if (
 						$innerType->hasOffsetValueType($innerDimType)->no()
 					) {
-						if ($innerType->isString()->yes() && $innerDimType->isInteger()->yes()) {
+						if ($innerType->isString()->yes() && !$innerDimType->isInteger()->no()) {
 							continue;
 						}
 						$report = true;

Check warning on line 129 in src/Rules/Arrays/NonexistentOffsetInArrayDimFetchCheck.php

View workflow job for this annotation

GitHub Actions / Mutation Testing (8.3, ubuntu-latest) 

Escaped Mutant for Mutator "PHPStan\Infection\TrinaryLogicMutator":

@@ @@
 					if (
 						$innerType->hasOffsetValueType($innerDimType)->no()
 					) {
-						if ($innerType->isString()->yes() && $innerDimType->isInteger()->yes()) {
+						if (!$innerType->isString()->no() && $innerDimType->isInteger()->yes()) {
 							continue;
 						}
 						$report = true;
continue;
}
$report = true;
break 2;
}
Expand Down
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,6 +1326,11 @@ public function testBug9240(): void
$this->analyse([__DIR__ . '/data/bug-9240.php'], []);
}

public function testBug13688(): void
{
$this->analyse([__DIR__ . '/data/bug-13688.php'], []);
}

#[RequiresPhp('>= 8.4.0')]
public function testArrayFindKeyExisting(): void
{
Expand Down
19 changes: 19 additions & 0 deletions tests/PHPStan/Rules/Arrays/data/bug-13688.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php declare(strict_types = 1);

namespace Bug13688;

$inputs = [ '', ':' ];

foreach ( $inputs as $input )
{
$inputLen = \strlen($input);
$hasTrailingColon = $inputLen > 0 && $input[$inputLen-1] === ':';
echo $hasTrailingColon ? "{$input} has trailing colon\n" : "{$input} does not have trailing colon\n";
}

function directComparison(): void
{
/** @var 'a'|'abc' $s */
$s = 'a';
echo $s[0];
}
Loading