Simplify: pass $scopeBeforeArgs directly to getArrayFunctionAppendingType

Instead of pre-computing argument types from $scopeBeforeArgs and passing
them separately, just pass $scopeBeforeArgs as the scope. The function
already uses $scope->getType() for both the array type and argument types,
so passing the before-args scope gives correct results for both.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Analyser/ExprHandler/FuncCallHandler.php

@@ -390,22 +390,14 @@ public function processExpr(NodeScopeResolver $nodeScopeResolver, Stmt $stmt, Ex
 		) {
 			$arrayArg = $normalizedExpr->getArgs()[0]->value;
 
-			$callArgs = array_slice($normalizedExpr->getArgs(), 1);
-			$callArgTypes = [];
-			$callArgNativeTypes = [];
-			foreach ($callArgs as $callArg) {
-				$callArgTypes[] = $scopeBeforeArgs->getType($callArg->value);
-				$callArgNativeTypes[] = $scopeBeforeArgs->getNativeType($callArg->value);
-			}
-
 			$scope = $nodeScopeResolver->processVirtualAssign(
 				$scope,
 				$storage,
 				$stmt,
 				$arrayArg,
 				new NativeTypeExpr(
-					$this->getArrayFunctionAppendingType($functionReflection, $scope, $normalizedExpr, $callArgTypes),
-					$this->getArrayFunctionAppendingType($functionReflection, $scope->doNotTreatPhpDocTypesAsCertain(), $normalizedExpr, $callArgNativeTypes),
+					$this->getArrayFunctionAppendingType($functionReflection, $scopeBeforeArgs, $normalizedExpr),
+					$this->getArrayFunctionAppendingType($functionReflection, $scopeBeforeArgs->doNotTreatPhpDocTypesAsCertain(), $normalizedExpr),
 				),
 				$nodeCallback,
 			)->getScope();
@@ -643,23 +635,19 @@ private function getFunctionThrowPoint(
 		return null;
 	}
 
-	/**
-	 * @param Type[] $precomputedArgTypes
-	 */
-	private function getArrayFunctionAppendingType(FunctionReflection $functionReflection, Scope $scope, FuncCall $expr, array $precomputedArgTypes): Type
+	private function getArrayFunctionAppendingType(FunctionReflection $functionReflection, Scope $scope, FuncCall $expr): Type
 	{
 		$arrayArg = $expr->getArgs()[0]->value;
 		$arrayType = $scope->getType($arrayArg);
 		$callArgs = array_slice($expr->getArgs(), 1);
 
 		/**
 		 * @param Arg[] $callArgs
-		 * @param Type[] $precomputedArgTypes
 		 * @param callable(?Type, Type, bool): void $setOffsetValueType
 		 */
-		$setOffsetValueTypes = static function (array $callArgs, callable $setOffsetValueType, array $precomputedArgTypes, ?bool &$nonConstantArrayWasUnpacked = null): void {
-			foreach ($callArgs as $i => $callArg) {
-				$callArgType = $precomputedArgTypes[$i];
+		$setOffsetValueTypes = static function (Scope $scope, array $callArgs, callable $setOffsetValueType, ?bool &$nonConstantArrayWasUnpacked = null): void {
+			foreach ($callArgs as $callArg) {
+				$callArgType = $scope->getType($callArg->value);
 				if ($callArg->unpack) {
 					$constantArrays = $callArgType->getConstantArrays();
 					if (count($constantArrays) === 1) {
@@ -693,11 +681,11 @@ private function getArrayFunctionAppendingType(FunctionReflection $functionRefle
 				$arrayTypeBuilder = $prepend ? ConstantArrayTypeBuilder::createEmpty() : ConstantArrayTypeBuilder::createFromConstantArray($constantArray);
 
 				$setOffsetValueTypes(
+					$scope,
 					$callArgs,
 					static function (?Type $offsetType, Type $valueType, bool $optional) use (&$arrayTypeBuilder): void {
 						$arrayTypeBuilder->setOffsetValueType($offsetType, $valueType, $optional);
 					},
-					$precomputedArgTypes,
 					$nonConstantArrayWasUnpacked,
 				);
 
@@ -733,6 +721,7 @@ static function (?Type $offsetType, Type $valueType, bool $optional) use (&$arra
 		}
 
 		$setOffsetValueTypes(
+			$scope,
 			$callArgs,
 			static function (?Type $offsetType, Type $valueType, bool $optional) use (&$arrayType): void {
 				$isIterableAtLeastOnce = $arrayType->isIterableAtLeastOnce()->yes() || !$optional;
@@ -743,7 +732,6 @@ static function (?Type $offsetType, Type $valueType, bool $optional) use (&$arra
 
 				$arrayType = TypeCombinator::union($arrayType, new ConstantArrayType([], []));
 			},
-			$precomputedArgTypes,
 		);
 
 		return $arrayType;