Simplify: use $scopeBeforeArgs instead of per-argument findBeforeScope

Instead of looking up the before-scope for each individual argument via
ExpressionResultStorage::findBeforeScope(), save the scope once before
processArgs and use that single scope for all argument type evaluations.

This is simpler and equivalent: the scope before args correctly reflects
the types at evaluation time for all value arguments.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Analyser/ExprHandler/FuncCallHandler.php

@@ -265,6 +265,7 @@ public function processExpr(NodeScopeResolver $nodeScopeResolver, Stmt $stmt, Ex
 			}
 		}
 
+		$scopeBeforeArgs = $scope;
 		$argsResult = $nodeScopeResolver->processArgs($stmt, $functionReflection, null, $parametersAcceptor, $normalizedExpr, $scope, $storage, $nodeCallbackForArgs, $context);
 		$scope = $argsResult->getScope();
 		$hasYield = $argsResult->hasYield();
@@ -393,9 +394,8 @@ public function processExpr(NodeScopeResolver $nodeScopeResolver, Stmt $stmt, Ex
 			$callArgTypes = [];
 			$callArgNativeTypes = [];
 			foreach ($callArgs as $callArg) {
-				$argBeforeScope = $storage->findBeforeScope($callArg->value) ?? $scope;
-				$callArgTypes[] = $argBeforeScope->getType($callArg->value);
-				$callArgNativeTypes[] = $argBeforeScope->getNativeType($callArg->value);
+				$callArgTypes[] = $scopeBeforeArgs->getType($callArg->value);
+				$callArgNativeTypes[] = $scopeBeforeArgs->getNativeType($callArg->value);
 			}
 
 			$scope = $nodeScopeResolver->processVirtualAssign(
@@ -443,23 +443,18 @@ public function processExpr(NodeScopeResolver $nodeScopeResolver, Stmt $stmt, Ex
 			$arrayArgType = $scope->getType($arrayArg);
 			$arrayArgNativeType = $scope->getNativeType($arrayArg);
 
-			$offsetArg = $normalizedExpr->getArgs()[1]->value;
-			$offsetBeforeScope = $storage->findBeforeScope($offsetArg) ?? $scope;
-			$offsetType = $offsetBeforeScope->getType($offsetArg);
+			$offsetType = $scopeBeforeArgs->getType($normalizedExpr->getArgs()[1]->value);
 
 			if (isset($normalizedExpr->getArgs()[2])) {
-				$lengthArg = $normalizedExpr->getArgs()[2]->value;
-				$lengthBeforeScope = $storage->findBeforeScope($lengthArg) ?? $scope;
-				$lengthType = $lengthBeforeScope->getType($lengthArg);
+				$lengthType = $scopeBeforeArgs->getType($normalizedExpr->getArgs()[2]->value);
 			} else {
 				$lengthType = new NullType();
 			}
 
 			if (isset($normalizedExpr->getArgs()[3])) {
 				$replacementArg = $normalizedExpr->getArgs()[3]->value;
-				$replacementBeforeScope = $storage->findBeforeScope($replacementArg) ?? $scope;
-				$replacementType = $replacementBeforeScope->getType($replacementArg);
-				$replacementNativeType = $replacementBeforeScope->getNativeType($replacementArg);
+				$replacementType = $scopeBeforeArgs->getType($replacementArg);
+				$replacementNativeType = $scopeBeforeArgs->getNativeType($replacementArg);
 			} else {
 				$replacementType = new ConstantArrayType([], []);
 				$replacementNativeType = new ConstantArrayType([], []);