license-update: update website with new license info#1762
Open
ramsey wants to merge 4 commits intophp:masterfrom
Open
license-update: update website with new license info#1762ramsey wants to merge 4 commits intophp:masterfrom
ramsey wants to merge 4 commits intophp:masterfrom
Conversation
ramsey
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
Contributor
|
🚀 Preview for commit 2c14ed2 can be found at https://web-php-pr-1762.preview.thephp.foundation |
Contributor
|
🚀 Regression report for commit 2c14ed2 is at https://web-php-regression-report-pr-1762.preview.thephp.foundation |
derickr
reviewed
Jan 13, 2026
| This ensures that the license information can be read properly even when a | ||
| binary is shipped instead of source code. A text file containing license and | ||
| copyright information is sometimes given the filename "Notice" or "NOTICE," | ||
| and may be referred to as a "notice file." |
Member
There was a problem hiding this comment.
nit: The , in "NOTICE," and the . in "notice file." should be outside the "'s
Member
Author
There was a problem hiding this comment.
Those silly American style guides! 😉
I generally follow the MLA style guide in writing, but the APA style guide and AP stylebook also agree that commas and periods should be placed inside closing quotation marks.
However, I'm aware that British English generally places them outside closing quotation marks. Is it the style of php.net to follow the British style?
ramsey
force-pushed
the
php-license-update
branch
from
f42e1f4 to
e6d8db9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR encompasses the changes proposed in the PHP License Update RFC, for the PHP website.
Discussion is available on the internals mailing list.
Changes proposed for php-src are available at php/php-src#20904.