Skip to content

chore: sync workflow validation fixes from agents review#352

Merged
coisa merged 6 commits into
mainfrom
chore/344-skip-reports-tests-when-unavailable
May 22, 2026
Merged

chore: sync workflow validation fixes from agents review#352
coisa merged 6 commits into
mainfrom
chore/344-skip-reports-tests-when-unavailable

Conversation

@coisa
Copy link
Copy Markdown
Contributor

@coisa coisa commented May 22, 2026

Summary

Follow-up workflow-sync fixes requested by CodeRabbit review feedback in the agents repository context, then propagated to this branch after the rebase sequence.

Included changes

  • resources/github-actions/auto-resolve-conflicts.yml: keep branch filter declaration stable and explicit in the reusable workflow definition.
  • resources/github-actions/changelog.yml: tighten changelog dispatch condition for pull request target execution context.
  • .github/workflows/label-sync.yml: adjust permissions so label sync can apply updates when intended.
  • docs/_static/mascot-banner.png: synchronize managed static asset state from the reviewed source.
  • .github/wiki submodule pointer: keep pointer aligned to the expected managed commit (generated by sync flow).

Notes

  • Temporary .github/mcp.json experiment was removed and not included.
  • .gitattributes test-only line (.github/workflows/*.lock.yml linguist-generated=true merge=ours) was intentionally removed from this PR.

Related

  • Originated from corrections surfaced in agents workflow-validation review.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates GitHub Actions workflow configurations to refine permissions and conditional execution logic, advances the wiki submodule reference, and documents these fixes in the changelog. Three workflow files receive targeted updates for permission scoping and trigger conditions; the wiki pointer is synchronized to a new revision.

Changes

Workflow Configuration and Git Artifacts

Layer / File(s) Summary
Workflow permissions and execution conditions
.github/workflows/label-sync.yml, resources/github-actions/auto-resolve-conflicts.yml, resources/github-actions/changelog.yml
Label-sync workflow gains issues: write permission. Auto-resolve-conflicts push trigger branches list is reformatted. Changelog job receives a conditional guard to run only for pull_request events or merged pull_request_target events.
Wiki submodule reference update
.github/wiki
Wiki submodule commit SHA is updated to reference a new revision.
Changelog documentation
CHANGELOG.md
Unreleased → Fixed section entry documents the workflow validation sync fix including workflow metadata, managed asset references, dispatch conditions, label-sync permissions, and submodule/wiki pointer alignment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

A rabbit hops through workflows with care,
Permissions granted, conditions fair—
The wiki spins 'round to a brand new place,
While CHANGELOG notes the sync's gentle grace. ✨🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description is substantially complete, providing a clear summary of included changes and notes, though it deviates from the standard template structure by using custom section headings instead of the repository's prescribed template format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title references 'workflow validation fixes from agents review' which aligns with the PR objectives describing workflow-sync fixes and corrections from an agents repository review.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/344-skip-reports-tests-when-unavailable

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

@coisa coisa changed the title chore: align workflow sync metadata for issue 347 chore: sync workflow validation fixes from agents review May 22, 2026
@coisa coisa merged commit 35b5f78 into main May 22, 2026
34 checks passed
@coisa coisa deleted the chore/344-skip-reports-tests-when-unavailable branch May 22, 2026 16:22
@github-project-automation github-project-automation Bot moved this from Backlog to Released in PHP Fast Forward Project May 22, 2026
github-actions Bot added a commit that referenced this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

1 participant