Fix removeListener issue in WearMessagingClient and WearNodeDiscovery caused by SAM autoboxing#11
Open
MonteCreasor wants to merge 1 commit intophilipplackner:masterfrom
Open
Conversation
Added two tests demonstrating that passing lambdas directly to MessageClient.addListener and CapabilityClient.addListener results in removeListener failing to remove them due to SAM autoboxing. This commit also includes temporary test dependencies required to run these tests, which should be removed before merging.
MonteCreasor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in
WearMessagingClientandWearNodeDiscoverywhereremoveListenerwas not correctly removing the previously registered listener.Issue
The problem occurs because Kotlin function types
(EventType) -> Unitare not the same as the expected Java SAM interfaces (MessageClient.OnMessageReceivedListenerandCapabilityClient.OnCapabilityChangedListener). When using a lambda directly, Kotlin boxes it into an anonymous class, causingremoveListenerto receive a different instance thanaddListener, which prevents proper removal.Fix
OnMessageReceivedListenerandOnCapabilityChangedListener) instead of using raw lambdas.addListenerandremoveListener.Temporary Changes
Impact
This fix ensures that listeners are properly removed, preventing memory leaks and unexpected event handling when the flow is closed.
Please review and let me know if any changes are needed.