LLVM: add AggregateAllocaSplitting transformation#1649
Merged
Conversation
phate
changed the title
phate
force-pushed
the
RvsdgTreePrinter-SplitableAllocas
branch
3 times, most recently
from
e43c5b2 to
072fc75
Compare
phate
force-pushed
the
RvsdgTreePrinter-SplitableAllocas
branch
2 times, most recently
from
5a6940f to
9187240
Compare
phate
force-pushed
the
RvsdgTreePrinter-SplitableAllocas
branch
from
9870b70 to
e049378
Compare
Owner
Author
|
@haved This one is now ready for review. |
haved
previously approved these changes
May 16, 2026
Collaborator
haved
left a comment
haved
left a comment
There was a problem hiding this comment.
Looks good. I have some comments you can look at it you'd like. The code for finding all users of the alloca and all users of the GEP is very similar, so it makes me wish for a "reverse tracer" in the future
Owner
Author
Yes, it is on my TODO list, but I was too lazy to factor it out for this PR now. |
Owner
Author
|
@haved I replied to all your comments. |
haved
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.