boost::intrusive_list#1245
Open
caleridas wants to merge 1 commit into
Open
Conversation
Owner
|
@haved What do you think? |
Collaborator
|
The interface looks fine. I think the bigger question is whether or not we want to add a dependency on boost. It would let us remove our own intrusive list implementation, which is nice. Boost is an extremely common dependency, so it would not really be a problem to add it. Personally I would be fine with adding it. @phate @caleridas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI, what using boost::intrusive_list would look like (i.e. essentially the same).
Not for merge right now, but for illustration.