More configuration options when initializing ga#18
Open
Soulou wants to merge 1 commit intopgrippi:masterfrom
Soulou:custom_analitycs_js_statements
Open
More configuration options when initializing ga#18Soulou wants to merge 1 commit intopgrippi:masterfrom Soulou:custom_analitycs_js_statements
Soulou wants to merge 1 commit intopgrippi:masterfrom
Soulou:custom_analitycs_js_statements
Conversation
|
👍 |
| if (config.extraCreateParams) { | ||
| createString += ", " + JSON.stringify(config.extraCreateParams); | ||
| } | ||
| createString += ");"; |
Collaborator
There was a problem hiding this comment.
Probably some potentially reusable code here. For example:
function makeFunctionDefinition(funcName, funcArgs) {
return '' + funcName + '(' + funcArgs.map(function(x) {return "'" + x + "'";}).join(', ') + ');';
}makeFunctionDefinition('GA', ['create', 'a', 'b']); // "GA('create', 'a', 'b');"|
Would love to use this lib but need the linker statement. +1 |
|
Hi, How do I set domain name for GA.Kindly can one help me . Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to add more configuration statements in my Analytics initialization, so here is my implementation
Will result in
Everything is compatible with the existing code