Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2291d870c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
templates/externalsecret.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| {{- if and .Values.externalSecrets.enabled .Values.externalSecrets.create }} | |||
| apiVersion: external-secrets.io/v1beta1 | |||
| apiVersion: external-secrets.io/v1 | |||
There was a problem hiding this comment.
Hard-coding external-secrets.io/v1 makes installs fail on clusters still running external-secrets versions that only serve external-secrets.io/v1beta1. This is a regression from the previous template behavior for those environments: rendering succeeds but apply fails with no matches for kind "ExternalSecret" because the API version is not served. Please select the API version conditionally (for example via .Capabilities.APIVersions.Has) so both CRD versions remain installable.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
That's fair. Ill make it backwards compatible
There was a problem hiding this comment.
Verified rendering:
- with
--api-versions external-secrets.io/v1→ rendersapiVersion: external-secrets.io/v1 - with
--api-versions external-secrets.io/v1beta1→ rendersapiVersion: external-secrets.io/v1beta1
There was a problem hiding this comment.
Haha I do this too, literally open-ended conversations with Claude 😆
|
Thank you! Will release this asap. |
|
Released in v0.45. |
2 participants
This updates ExternalSecret resources to use external-secrets.io/v1.
On clusters where only v1 is served, the chart currently fails with:
no matches for kind ExternalSecret in version external-secrets.io/v1beta1