Skip to content

Integrate Backrest Configuration Handling into add_node Function#296

Merged
mmols merged 19 commits into
REL25_01from
add-node/25_01
Apr 15, 2025
Merged

Integrate Backrest Configuration Handling into add_node Function#296
mmols merged 19 commits into
REL25_01from
add-node/25_01

Conversation

@moizpgedge
Copy link
Copy Markdown
Contributor

@moizpgedge moizpgedge commented Apr 14, 2025

feat: advanced backrest installation & JSON validation for add-node

    • Install Backrest on a source node that does not have Backrest configured, then create a backup
    • If target node is specified in JSON, install and configure Backrest on the target node; otherwise, clean up Backrest
    • Extend JSON validation in the add-node function to validate the target node’s Backrest configuration
    • Perform cleanup tasks on the source node
    • Append target node information to the cluster JSON file
    • Throw an error if repo1_path is provided and the source node is already configured with Backrest
    • Ensure repo1_path flag is properly recognized and functional

moizpgedge and others added 16 commits April 14, 2025 06:20
@moizpgedge
yaml file created for backrest json in backrest dir
d1a9b8f
@moizpgedge
yaml file created for backrest json in backrest dir
d5ad11a
@moizpgedge
Update cluster.py
3515dd3 
json validate add
@mmols @moizpgedge
add build_cli.sh script
895ee3c
@mmols @moizpgedge
mount host github repo in container
ee4a264
@moizpgedge
backrest installing on none backrest configured source node creating …
f6aa5d1 
…backup , backrest installing on target if mentioned in target json and configuring backrest/taking backup else cleanup of backrest
@moizpgedge
backrest configuration setup modified on add-node for source node
3d41040
@moizpgedge
json validate add node function now validate backrest of target node
fb44ac0
@moizpgedge
source node cleanup
89f9c9c
@moizpgedge
target node append on cluster json file
298e5fc
@moizpgedge
yaml file for backrest created for each node in add node
4eecdd4
@moizpgedge
backrest config updated by using ./pgedge backrest update-config
f620d62
@moizpgedge
if repo1_path is provided in flag and source node is already configu…
0a75595 
…red with backrest then it will throw error
@moizpgedge
repo1_path flag is working
b4453d9
@moizpgedge
Revert "backrest config updated by using ./pgedge backrest update-con…
466fb1f 
…fig"

This reverts commit 3c70598.
@moizpgedge
Revert "yaml file for backrest created for each node in add node"
c890a0c 
This reverts commit 279acfe.
@moizpgedge moizpgedge requested a review from mmols April 14, 2025 01:26
mmols
mmols requested changes Apr 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mmols mmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally this is looking good - I've left comments for cleanup before we merge.

Comment thread cli/scripts/cluster.py
Comment thread cli/scripts/cluster.py
Comment thread cli/scripts/cluster.py
Comment thread cli/scripts/cluster.py Outdated
Comment thread cli/scripts/cluster.py Outdated
Comment thread cli/scripts/cluster.py Outdated
Comment thread cli/scripts/cluster.py Outdated
Comment thread cli/scripts/cluster.py Outdated
Comment thread cli/scripts/cluster.py Outdated
Comment thread cli/scripts/cluster.py
@moizpgedge moizpgedge changed the title Add node/25 01 Integrate Backrest Configuration Handling into add_node Function Apr 14, 2025
@moizpgedge moizpgedge requested a review from mmols April 14, 2025 23:33
@mmols mmols merged commit 477f558 into REL25_01 Apr 15, 2025
9 checks passed
@mmols mmols deleted the add-node/25_01 branch April 15, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmols mmols Awaiting requested review from mmols

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moizpgedge @mmols