feat(server,alerter): add Gemini embedding support; bump default chat model#248
Open
dpage wants to merge 1 commit into
Open
feat(server,alerter): add Gemini embedding support; bump default chat model#248dpage wants to merge 1 commit into
dpage wants to merge 1 commit into
Conversation
… model Expose Gemini as a fourth embedding provider via the server's EmbeddingConfig and KnowledgebaseConfig structs; the underlying pkg/embedding/gemini.go provider already existed but was unreachable from YAML. Update the default Gemini chat model from gemini-2.0-flash (no longer available to new API tier keys) to gemini-2.5-flash in alerter code, server test fixtures, and example configs. Closes #246
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server/knowledgebaseconfig (the underlying
pkg/embedding/gemini.goprovider already existedbut was unreachable from YAML). Supports
text-embedding-004andembedding-001(both 768 dims).gemini-2.0-flash(no longeravailable to new API tier keys, returns 404) to
gemini-2.5-flashinalerter code, server test fixtures, and example configs.
pkg/embedding/README.mdand the server configuration guide; note that model availability
varies by Gemini API key tier and recommend running ListModels.
Test plan
make test-allpasses (server, alerter, collector, client)go vet ./...clean inserver/srcandalerter/srcgofmt -lcleangolangci-lintreports 0 issues in server and alerterand Gemini-provider construction via
generate_embeddings,similarity_search, andsearch_knowledgebasetools (httptest-stubbedGemini endpoint).
grep -rn "gemini-2.0-flash"clean except for the changelog entrythat intentionally records the bump.
Closes #246