Add Save a Copy as XML translator to fm_xml_to_snippet#38
Open
kirkabowman wants to merge 1 commit into
Open
Conversation
The generic translator drops UniversalPathList (its text type doesn't reach into <Location>) and ignores the Boolean Option (no branch), producing incomplete output. Hand-coded translator emits Option, UniversalPathList, and Calculation correctly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hand-coded translator for the Save a Copy as XML script step. The generic translator falls short on this step in two ways:
UniversalPathList'stexttype doesn't reach into the<Location>child element, so the path is droppedBooleanOption produces no<Option state=...>branch in the generic pathThe new
tx_save_copy_as_xmlcorrectly emits all three params (Option, UniversalPathList, Calculation) so converted scripts round-trip cleanly.Test plan
fm_xml_to_snippet.pyand paste back into FM; confirm path, window calc, and Automatically Open option all survive🤖 Generated with Claude Code