Remove use of OwnPtr in AP_Compass#41
Open
peterbarker wants to merge 4 commits into
Open
Conversation
only used from hwdef files at this point
68acf83 to
0e2140a
Compare
fff6c63 to
f1d79f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops using OwnPtr in the compass library.
Into the future will allow further tidying of probing (removing external and rotation arguments not needed for probing), and removal of resource leaks (e.g. compass backend pointers when add_backend fails.
Fixed a release of bus pointer in the case of an allocation failure for sensor (minor problem, may not be worth the flash, maybe just comment it instead?
Classification & Testing (check all that apply and add your own)
Description