[BUGFIX] Threshold color picker goes crazy when holding the mouse cli…#77
Merged
ibakshay merged 1 commit intoperses:mainfrom Mar 3, 2026
Merged
Conversation
Contributor
|
@adrianSepiol thnx for this. Please add your DCO |
jgbernalp
approved these changes
Mar 3, 2026
acf852e to
8f54191
Compare
…ck down Signed-off-by: Adrian Sepiół <adisepko@gmail.com>
8f54191 to
4222532
Compare
ibakshay
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes TimeSeriesChart: Threshold color picker goes crazy when holding the mouse click down
Eliminated redundant useState/useEffect pattern that was duplicating the steps state from props. The component was maintaining its own copy of the threshold steps and syncing it via useEffect, which created a race condition where simultaneous updates from useEffect setState calls and onChange callbacks would override each other, causing infinite loops.
Now the component relies solely on the external state passed via props as the single source of truth, ensuring consistent updates without conflicting state synchronization.
Screenshots
Screencast.from.03-03-2026.10.29.42.AM.webm
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
See e2e docs for more details. Common issues include: