Add SonarQube generic import formatter#1088
Open
kapitoshka438 wants to merge 2 commits intoperipheryapp:masterfrom
Open
Add SonarQube generic import formatter#1088kapitoshka438 wants to merge 2 commits intoperipheryapp:masterfrom
kapitoshka438 wants to merge 2 commits intoperipheryapp:masterfrom
Conversation
kapitoshka438
force-pushed
the
sonarqube-formatter
branch
from
b76282f to
c4b6deb
Compare
Author
|
@ileitch please review |
There was a problem hiding this comment.
Pull request overview
Adds a new output formatter that emits a SonarQube “Generic Issue Import” JSON report, enabling Periphery scan results to be imported as external issues in SonarQube (Issue #481).
Changes:
- Introduces
SonarQubeFormatterto encode scan results into SonarQube’s generic external-issues JSON schema. - Adds a new
sonarqubeoutput format and wires it into the formatter selection. - Adds configuration for selecting SonarQube rule severity (
sonarqube_rule_severity).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/PeripheryKit/Results/SonarQubeFormatter.swift | New formatter that encodes rules + issues into a SonarQube external issues JSON report. |
| Sources/PeripheryKit/Results/OutputFormatter.swift | Registers the new formatter for the .sonarQube output format. |
| Sources/Configuration/SonarQubeRuleSeverity.swift | Adds an enum representing SonarQube severity levels. |
| Sources/Configuration/OutputFormat.swift | Adds a new sonarqube output format option. |
| Sources/Configuration/Configuration.swift | Adds a new YAML setting for configuring SonarQube rule severity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@copilot code review[agent] |
Author
|
@ileitch I've made changes, please re-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#481
This PS adds a new formatter for SonarQube External Issues Report.
https://docs.sonarsource.com/sonarqube-server/analyzing-source-code/importing-external-issues/generic-issue-import-format