Test Octane request context provider#12
Open
glensc wants to merge 5 commits into
Open
Conversation
- Cover captured request and env snapshot behavior. - Lock active request replacement and missing-state failure.
- Cover profiler reuse and stale worker recovery. - Verify cleanup and request-context handling on failures.
- Assert provider binding and sandbox profiler handoff through the manager - Lock disabled-request recovery and safe stop failure logging behavior
There was a problem hiding this comment.
Pull request overview
Adds a focused Octane test suite to validate request-context capture and the Octane worker profiler lifecycle integration for this Laravel bridge.
Changes:
- Add integration-style tests asserting
XhguiProfilerServiceProviderbinds and usesOctaneWorkerProfilerManageracross Octane request events. - Add unit tests for
OctaneWorkerProfilerManagercovering profiler reuse and stale/running-state recovery behavior. - Add unit tests for
OctaneRequestContextProvidersnapshot capture and failure behavior when inactive.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Octane/XhguiProfilerOctaneLifecycleTest.php | Exercises Octane request received/terminated flows and verifies sandbox profiler binding/cleanup and error logging. |
| tests/Octane/OctaneWorkerProfilerManagerTest.php | Verifies worker-level profiler reuse and stale-state recovery behavior, including logging and context clearing on failures. |
| tests/Octane/OctaneRequestContextProviderTest.php | Verifies request context snapshot capture and inactive-context exception behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+63
to
+67
| $provider = new OctaneRequestContextProvider(new OctaneRequestContextState); | ||
|
|
||
| $this->expectException(RuntimeException::class); | ||
| $this->expectExceptionMessage('Octane request context is not active.'); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Updated in 57a23c0: the Octane request-context test now expects LaravelProfilerException instead of RuntimeException, and related Octane manager assertion/imports were aligned to the same exception contract. No UI changes were involved (no screenshot applicable).
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/perftools/php-profiler-laravel/sessions/e93f4de5-71ef-4fe6-b263-91ee5b033611 Co-authored-by: glensc <199095+glensc@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was extracted from #11 to reduce review noise
Pull request overview
Adds a focused Octane test suite to validate request-context capture and the Octane worker profiler lifecycle integration for this Laravel bridge.
Changes:
XhguiProfilerServiceProviderbinds and usesOctaneWorkerProfilerManageracross Octane request events.OctaneWorkerProfilerManagercovering profiler reuse and stale/running-state recovery behavior.OctaneRequestContextProvidersnapshot capture and failure behavior when inactive.