This repository was archived by the owner on Nov 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
PMM-10385 Explain tab. #186
Draft
JiriCtvrtka
wants to merge
32
commits into
main
Choose a base branch
from
PMM-10385-disable-examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
c451716
PMM-10385 New properties in getQueryExamples.
JiriCtvrtka 88bf2a6
PMM-10385 Fix test.
JiriCtvrtka 4a2ec65
PMM-10385 Lint.
JiriCtvrtka 9b8b7b0
PMM-10385 Fix test.
JiriCtvrtka b69b87e
PMM-10385 Fix test.
JiriCtvrtka 6ee0484
PMM-10385 Format.
JiriCtvrtka 211c8da
PMM-10385 Format.
JiriCtvrtka cd8eb9a
PMM-10385 Format.
JiriCtvrtka bbcabba
PMM-10385 Format.
JiriCtvrtka 7f28dff
PMM-10385 Fix sql parsing.
JiriCtvrtka de8c217
PMM-10385 Lint.
JiriCtvrtka bba68c9
PMM-10385 Changes.
JiriCtvrtka 134d055
PMM-10385 Fix.
JiriCtvrtka f5b018d
PMM-10385 Fix for get query by queryid.
JiriCtvrtka af0d090
PMM-10385 Changes.
JiriCtvrtka 96c5be2
PMM-10385 Changes.
JiriCtvrtka c04c55a
PMM-10385 Fix.
JiriCtvrtka 6b4eb85
PMM-10385 Changes.
JiriCtvrtka 9f8b1b9
PMM-10385 Fix.
JiriCtvrtka 86b818a
PMM-10385 Formatting.
JiriCtvrtka d19ec65
PMM-10385 Mod.
JiriCtvrtka 0c2ea54
PMM-10385 Change of behavior.
JiriCtvrtka c3cceae
PMM-10385 Fix format.
JiriCtvrtka 52c0162
PMM-10385 Remove test.
JiriCtvrtka 7769b6d
PMM-10385 Fix typo.
JiriCtvrtka b11491a
PMM-10385 Fix tests.
JiriCtvrtka d1b0242
PMM-10385 Mod.
JiriCtvrtka 551858d
PMM-10385 Regenerate data.
JiriCtvrtka d1b93c0
PMM-10385 Gen.
JiriCtvrtka 362cdb8
PMM-10385 Format.
JiriCtvrtka 9bb4907
PMM-10385 Format.
JiriCtvrtka c2b8b17
Revert "PMM-10385 Format."
JiriCtvrtka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ALTER TABLE metrics | ||
| DROP COLUMN `explain_fingerprint`, | ||
| DROP COLUMN `placeholders_count`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ALTER TABLE metrics | ||
| ADD COLUMN `explain_fingerprint` String, | ||
| ADD COLUMN `placeholders_count` UInt32; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci-lint] reported by reviewdog 🐶
ExplainFingerprint, PlaceholdersCount are missing in ExplainFingerprintByQueryIDReply (exhaustivestruct)