Skip to content

PMM-8877: turn ON IA by default, mark fields as deprecated #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oter wants to merge 8 commits into from
Closed

PMM-8877: turn ON IA by default, mark fields as deprecated #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ca69392
PMM-8877: turn ON IA by default, mark fields as deprecated
Oct 12, 2021
246cb77
Merge branch 'main' into PMM-8877-turn-on-ia-by-default
oter Oct 19, 2021
7d98d77
Merge branch 'main' into PMM-8877-turn-on-ia-by-default
oter Oct 21, 2021
283819c
Merge branch 'main' of github.com:percona/pmm into PMM-8877-turn-on-i…
Nov 9, 2021
3ca68f9
Merge branch 'main' into PMM-8877-turn-on-ia-by-default
oter Nov 16, 2021
501b2ce
vendoring
Nov 23, 2021
162c231
Merge branch 'main' into PMM-8877-turn-on-ia-by-default
artemgavrilov Nov 29, 2021
71030a0
Merge branch 'main' into PMM-8877-turn-on-ia-by-default
artemgavrilov Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/serverpb/json/client/server/change_settings_responses.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/serverpb/json/client/server/get_settings_responses.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions api/serverpb/json/serverpb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@
"x-order": 6
},
"alerting_enabled": {
"description": "True if Alerting is enabled.",
"description": "Alerting is always enabled and cannot be disabled.",
"type": "boolean",
"x-order": 11
},
Expand Down Expand Up @@ -644,7 +644,7 @@
"x-order": 6
},
"alerting_enabled": {
"description": "True if Alerting is enabled.",
"description": "Alerting is always enabled and cannot be disabled.",
"type": "boolean",
"x-order": 11
},
Expand Down
458 changes: 234 additions & 224 deletions api/serverpb/server.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions api/serverpb/server.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@ message Settings {
string platform_email = 10;
// True if DBaaS is enabled.
bool dbaas_enabled = 11;
// True if Alerting is enabled.
bool alerting_enabled = 12;
// Alerting email (SMTP) settings.
// Alerting is always enabled and cannot be disabled.
bool alerting_enabled = 12 [deprecated = true];
// Integrated Alerting email (SMTP) settings.
EmailAlertingSettings email_alerting_settings = 13;
// Alerting Slack settings.
SlackAlertingSettings slack_alerting_settings = 14;
Expand Down Expand Up @@ -230,9 +230,9 @@ message ChangeSettingsRequest {
// Disable Security Threat Tool.
bool disable_stt = 12;
// Enable Alerting.
bool enable_alerting = 13;
bool enable_alerting = 13 [deprecated = true];
// Disable Alerting.
bool disable_alerting = 14;
bool disable_alerting = 14 [deprecated = true];
// Change Alerting email (SMTP) settings, if set.
EmailAlertingSettings email_alerting_settings = 15;
// If true, removes Alerting email (SMTP) settings.
Expand Down
4 changes: 2 additions & 2 deletions api/swagger/swagger-dev.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2574,7 +2574,7 @@
"x-order": 10
},
"alerting_enabled": {
"description": "True if Alerting is enabled.",
"description": "Alerting is always enabled and cannot be disabled.",
"type": "boolean",
"x-order": 11
},
Expand Down Expand Up @@ -2827,7 +2827,7 @@
"x-order": 10
},
"alerting_enabled": {
"description": "True if Alerting is enabled.",
"description": "Alerting is always enabled and cannot be disabled.",
"type": "boolean",
"x-order": 11
},
Expand Down
4 changes: 2 additions & 2 deletions api/swagger/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@
"x-order": 10
},
"alerting_enabled": {
"description": "True if Alerting is enabled.",
"description": "Alerting is always enabled and cannot be disabled.",
"type": "boolean",
"x-order": 11
},
Expand Down Expand Up @@ -706,7 +706,7 @@
"x-order": 10
},
"alerting_enabled": {
"description": "True if Alerting is enabled.",
"description": "Alerting is always enabled and cannot be disabled.",
"type": "boolean",
"x-order": 11
},
Expand Down