Conversation
|
I really hope CI will catch that… |
|
And yes, CI fails. Run |
|
@AlekSi sorry, fixed. |
AlekSi
left a comment
AlekSi
left a comment
There was a problem hiding this comment.
We need to add SaaS user email to Settings message
api/serverpb/server.proto
Outdated
| // SignUp creates user Percona profile. | ||
| rpc SignUp(SignUpRequest) returns (SignUpResponse) { | ||
| option (google.api.http) = { | ||
| post: "/v1/Auth/SignUp" |
There was a problem hiding this comment.
Let me think about that URL…
I will do that |
|
Ok |
AlekSi
left a comment
AlekSi
left a comment
There was a problem hiding this comment.
@artemgavrilov PTAL at recent commits
| } | ||
| ]; | ||
| // New Percona Platform user's password. | ||
| string password = 2; |
There was a problem hiding this comment.
The presence of that field should be validated in code. In the future, we will relax that requirement. Removing a validator would be a breaking change from prototool perspective.
| } | ||
| ]; | ||
| // Existing Percona Platform user's password. | ||
| string password = 2; |
There was a problem hiding this comment.
The presence of that field should be validated in code. In the future, we will relax that requirement. Removing a validator would be a breaking change from prototool perspective.
| post: "/v1/Platform/SignIn" | ||
| body: "*" | ||
| }; | ||
| } |
There was a problem hiding this comment.
Changed both URLs and method names
| } | ||
|
|
||
| http { | ||
| upstream managed-grpc { |
There was a problem hiding this comment.
See the added comment on top of the file
3 participants
Implemented in: percona/pmm-managed#420
Feature build: Percona-Lab/pmm-submodules#967