Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
+ Coverage 43.47% 43.84% +0.36%
==========================================
Files 355 354 -1
Lines 42053 41683 -370
==========================================
- Hits 18284 18277 -7
+ Misses 22174 21810 -364
- Partials 1595 1596 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
floatinginbits
approved these changes
Nov 14, 2022
| err := s.qanClient.QueryExists(ctx, serviceID, query) | ||
| if err != nil { | ||
| return err | ||
| func (s *ActionsService) StartMySQLExplainAction(ctx context.Context, id, pmmAgentID, serviceID, dsn, query, queryID string, placeholders []string, format agentpb.MysqlExplainOutputFormat, files map[string]string, tdp *models.DelimiterPair, tlsSkipVerify bool) error { |
Contributor
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 268 characters (lll)
|
|
||
| // makeBuckets is a pure function for easier testing. | ||
| func makeBuckets(agentID string, res event.Result, periodStart time.Time, periodLengthSecs uint32, disableQueryExamples bool, maxQueryLength int32) []*agentpb.MetricsBucket { //nolint:cyclop,lll | ||
| func makeBuckets(agentID string, res event.Result, periodStart time.Time, periodLengthSecs uint32, disableQueryExamples bool, maxQueryLength int32, l *logrus.Entry) []*agentpb.MetricsBucket { |
Contributor
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 191 characters (lll)
BupycHuk
reviewed
Nov 30, 2022
|
|
||
| // MySQL parse query and return fingeprint and placeholders. | ||
| func MySQL(q string) (string, uint32, error) { | ||
| normalizedQuery, _, err := sqlparser.Parse2(q) |
Contributor
There was a problem hiding this comment.
it seems like a just query
BupycHuk
reviewed
Nov 30, 2022
| return "", 0, errors.Wrap(err, "cannot normalize query") | ||
| } | ||
|
|
||
| parsedQuery := sqlparser.NewParsedQuery(normalizedQuery) |
Contributor
There was a problem hiding this comment.
sqlparser.String would return the query we need
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-10385
Build: SUBMODULES-2835