PMM-5885 upgrade postgres to 14 by nikita-b · Pull Request #212 · percona/pmm-update

nikita-b · 2022-05-11T15:15:08Z

Links to other linked pull requests (optional).

…pmm-update into PMM-5885-upgrade-postgres-to-14

codecov · 2022-05-19T04:48:08Z

Codecov Report

Merging #212 (8a6f63f) into main (cd99f51) will decrease coverage by 1.88%.
The diff coverage is n/a.

❗ Current head 8a6f63f differs from pull request most recent head 3e1bab3. Consider uploading reports for the commit 3e1bab3 to get more accurate results

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   49.05%   47.16%   -1.89%     
==========================================
  Files           5        5              
  Lines         318      318              
==========================================
- Hits          156      150       -6     
- Misses        143      148       +5     
- Partials       19       20       +1

Flag	Coverage Δ
runcover	`47.16% <ø> (-1.89%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/yum/yum.go	`57.14% <0.00%> (-7.15%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd99f51...3e1bab3. Read the comment docs.

ademidoff · 2022-05-19T09:00:06Z

@nikita-b We also need to update the logic for <pmm-server/logs.zip endpoint, since it exports postgres logs as well.

The links:

ansible/playbook/tasks/roles/postgres/tasks/main.yml

ansible/playbook/tasks/roles/initialization/tasks/main.yml

Co-authored-by: Alex Tymchuk <alexander.tymchuk@gmail.com>

nikita-b · 2022-05-25T14:40:10Z

@atymchuk percona/pmm-managed#1133

…pmm-update into PMM-5885-upgrade-postgres-to-14

nikita-b · 2022-06-14T09:29:04Z

ansible/playbook/tasks/files/pmm.ini

+stdout_logfile = /srv/logs/pmm-update-perform.log
+stdout_logfile_maxbytes = 50MB
+stdout_logfile_backups = 3
+redirect_stderr = true


It was moved from pmm-server package

nikita-b · 2022-06-14T09:29:48Z

ansible/playbook/tasks/roles/initialization/tasks/main.yml

+- name: Upgrade Postgres database
  include_role:
-    name: postgres-ascii-to-utf8
-  when: "'SQL_ASCII' == postgres_encoding.query_result[0].server_encoding"


I removed this role because we use new instance and this instance has UTF8 by default

nikita-b · 2022-06-14T09:30:04Z

ansible/playbook/tasks/roles/postgres/tasks/main.yml

+      - percona-postgresql11
+      - python-psycopg2
+    state: installed
+  when: not ansible_check_mode


We need old postgres for migration

nikita-b · 2022-06-14T09:30:29Z

ansible/playbook/tasks/update.yml

+        section: supervisord
+        state: absent
+      when: not is_docker
+


It was migrated from pmm-server repo and package

nikita-b added 11 commits May 11, 2022 15:14

PMM-5885 upgrade postgres to 14

1526028

fix

0899905

Merge branch 'main' into PMM-5885-upgrade-postgres-to-14

605d914

PMM-5885 clean yum

507feaf

Merge branch 'PMM-5885-upgrade-postgres-to-14' of github.com:percona/…

abbfd23

…pmm-update into PMM-5885-upgrade-postgres-to-14

fix check mode

241f53d

fix service name

79983bc

fix become

fea7544

fix

0d6c64b

ansible check

2a6eb65

fix syntax

f8ad500

nikita-b requested a review from ademidoff May 19, 2022 06:49

nikita-b marked this pull request as ready for review May 19, 2022 06:50

nikita-b requested a review from BupycHuk as a code owner May 19, 2022 06:50

ademidoff suggested changes May 19, 2022

View reviewed changes

nikita-b and others added 6 commits May 19, 2022 16:08

Update ansible/playbook/tasks/roles/postgres/tasks/main.yml

d323438

Co-authored-by: Alex Tymchuk <alexander.tymchuk@gmail.com>

Update ansible/playbook/tasks/roles/initialization/tasks/main.yml

d8fe797

Co-authored-by: Alex Tymchuk <alexander.tymchuk@gmail.com>

Merge branch 'main' into PMM-5885-upgrade-postgres-to-14

b7f3838

Update ansible/playbook/tasks/roles/postgres/tasks/main.yml

4eaead7

Co-authored-by: Alex Tymchuk <alexander.tymchuk@gmail.com>

Update ansible/playbook/tasks/roles/postgres/tasks/main.yml

0676ea1

Co-authored-by: Alex Tymchuk <alexander.tymchuk@gmail.com>

Update ansible/playbook/tasks/roles/postgres/tasks/main.yml

7f6cdcb

Co-authored-by: Alex Tymchuk <alexander.tymchuk@gmail.com>

nikita-b added 6 commits May 26, 2022 16:47

fix

40b09b5

Merge branch 'PMM-5885-upgrade-postgres-to-14' of github.com:percona/…

a153011

…pmm-update into PMM-5885-upgrade-postgres-to-14

fix

ffb52fd

fix

c1d0ae1

fix python deps

44e3e48

fix ext postgres

a02cbcc

nikita-b added 17 commits May 31, 2022 00:42

Merge branch 'main' into PMM-5885-upgrade-postgres-to-14

5f95392

fix

9cd07e3

Merge branch 'PMM-5885-upgrade-postgres-to-14' of github.com:percona/…

6b56d72

…pmm-update into PMM-5885-upgrade-postgres-to-14

move supervisor settings from pmm-server

166f71f

fix

b9c372f

fix module name

11fea48

fix upgrade bug

46835de

Merge branch 'main' into PMM-5885-upgrade-postgres-to-14

71e2154

fix upgrade

ed00819

Merge branch 'PMM-5885-upgrade-postgres-to-14' of github.com:percona/…

650bef6

…pmm-update into PMM-5885-upgrade-postgres-to-14

fix

dcd7323

fix upgrade

df80942

fix

da42706

fix

f411364

remove useless steps

eba1cf0

fix supervisor issues

2bae6d2

fix

4b8a1fd

nikita-b marked this pull request as draft June 8, 2022 07:51

nikita-b added 2 commits June 10, 2022 10:29

add pmm-managed user

fbfe714

fix

3e1bab3

nikita-b marked this pull request as ready for review June 14, 2022 09:28

nikita-b commented Jun 14, 2022

View reviewed changes

This was referenced Jun 27, 2022

PMM-5885-upgrade-postgres-to-14 (FB) Percona-Lab/pmm-submodules#2529

Closed

SUBMODULES-TEST-123 Percona-Lab/pmm-submodules#2611

Closed

Merge branch 'main' into PMM-5885-upgrade-postgres-to-14

a3263dd

nikita-b merged commit 86cfe1b into main Jul 19, 2022

nikita-b deleted the PMM-5885-upgrade-postgres-to-14 branch July 19, 2022 07:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PMM-5885 upgrade postgres to 14#212

PMM-5885 upgrade postgres to 14#212
nikita-b merged 46 commits intomainfrom
PMM-5885-upgrade-postgres-to-14

nikita-b commented May 11, 2022 •

edited

Loading

Uh oh!

codecov bot commented May 19, 2022 •

edited

Loading

Uh oh!

ademidoff commented May 19, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikita-b commented May 25, 2022

Uh oh!

nikita-b Jun 14, 2022

Uh oh!

nikita-b Jun 14, 2022

Uh oh!

nikita-b Jun 14, 2022

Uh oh!

nikita-b Jun 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nikita-b commented May 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ademidoff commented May 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikita-b commented May 25, 2022

Uh oh!

nikita-b Jun 14, 2022

Choose a reason for hiding this comment

Uh oh!

nikita-b Jun 14, 2022

Choose a reason for hiding this comment

Uh oh!

nikita-b Jun 14, 2022

Choose a reason for hiding this comment

Uh oh!

nikita-b Jun 14, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nikita-b commented May 11, 2022 •

edited

Loading

codecov bot commented May 19, 2022 •

edited

Loading

ademidoff commented May 19, 2022 •

edited

Loading