Note use of direct conneciton with --split-cluser#1134
Open
dobesv wants to merge 4 commits intopercona:mainfrom
Open
Note use of direct conneciton with --split-cluser#1134dobesv wants to merge 4 commits intopercona:mainfrom
--split-cluser#1134dobesv wants to merge 4 commits intopercona:mainfrom
Conversation
I found that when using `--split-cluster` you should also use direct connections, otherwise it just only connects to the same replica and reports its metrics as if all the replicas have exactly the same metric values.
dobesv
requested review from
a team,
BupycHuk and
JiriCtvrtka
and removed request for
a team
|
|
idoqo
approved these changes
Sep 27, 2025
Contributor
|
@dobesv could you sign CLA? Thank you. |
JiriCtvrtka
approved these changes
Oct 24, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
==========================================
- Coverage 70.88% 64.82% -6.07%
==========================================
Files 28 29 +1
Lines 3569 2428 -1141
==========================================
- Hits 2530 1574 -956
+ Misses 904 713 -191
- Partials 135 141 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
I don't mind ... but when I try, I get an error: 
Maybe easier if you just recreate the same trivial change in a new PR. |
ademidoff
requested review from
ademidoff and
maxkondr
and removed request for
a team and
BupycHuk
maxkondr
approved these changes
Apr 15, 2026
Author
|
I was able to sign the CLA today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that when using
--split-clusteryou should also use direct connections, otherwise it just only connects to the same replica and reports its metrics as if all the replicas have exactly the same metric values.