[TDB-20] With checkpoint disabled, closing FT file still rotates header.#409
Open
Jun-Yuan wants to merge 1 commit intopercona:masterfrom
Open
[TDB-20] With checkpoint disabled, closing FT file still rotates header.#409Jun-Yuan wants to merge 1 commit intopercona:masterfrom
Jun-Yuan wants to merge 1 commit intopercona:masterfrom
Conversation
[Updated the comments and formats from the last PR.]
This is an attempt based on @bohutang's patch
percona#331
in particular, the ctest mostly comes from his with minor updates.
Summary:
1) The issue is real.
2) @bohu's patch works for mediating the issue but somewhat introduces
a ft leak that the ft with ref=0 may be left until next open/close or
checkpoint.
3) If ft_close should be held off upon a backup, then it simply means
a backup should hold a ref to the ft and responsible for closing ft up
if it is the last one to hold it, like any other possible referencer.
including the checkpoint, the txn and ft handlers.
4) mtr test contributed by @bohutang still passes. (in a different PS PR).
Contributor
|
Hello, Any updates regarding this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jenkin: https://jenkins.percona.com/view/TokuDB/job/PerconaFT-param/120/
[Updated the comments and formats from the last PR.]