Migrated linter fix - (Built on django-migrate and NOT main)#312
Open
Migrated linter fix - (Built on django-migrate and NOT main)#312
Conversation
judtinzhang
reviewed
Apr 16, 2024
Contributor
Author
|
Main issue with codecov is just the token I believe. Error message on running codecov: 'Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.' If the upload token is shared I'll keep looking into it. If it's ohq specific, I'll need to ask Bach or Dan to add it into our secrets |
Member
|
Makes sense, lmk if you stumble into anything else |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## django-migrate #312 +/- ##
=================================================
Coverage ? 98.93%
=================================================
Files ? 25
Lines ? 1316
Branches ? 0
=================================================
Hits ? 1302
Misses ? 14
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Codecov token added. All tests pass. |
judtinzhang
approved these changes
Apr 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore backend checks for ohq deployment.