fix: convert ADF description to text for markdown/detail output#22
Merged
fix: convert ADF description to text for markdown/detail output#22
Conversation
JIRA API v3 returns description as ADF (Atlassian Document Format) JSON object instead of plain string. This caused [object Object] to be displayed when viewing issues with --format markdown or default detail view. Closes #21
Address GHSA-3p68-rc4w-qgx5 (SSRF via NO_PROXY bypass) and GHSA-fvcv-3m26-pcqx (cloud metadata exfiltration via header injection).
|
🎉 This PR is included in version 2.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Fix
--format markdownand default detail view outputting[object Object]instead of actual description content when using JIRA API v3.🎯 Type of Change
🔍 Changes Made
convertAdfToText()function to recursively convert ADF (Atlassian Document Format) JSON to readable text/markdownresolveDescription()wrapper that handles both string (API v2) and ADF object (API v3) descriptionsformatIssueAsMarkdown()anddisplayIssueDetails()🧪 Testing
📊 Test Results
🚀 Deployment Notes
📝 Checklist
🔗 Related Issues