Skip to content

Request size limiter #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zealsham wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Request size limiter #1410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions payjoin-mailroom/src/directory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const CHACHA20_POLY1305_NONCE_LEN: usize = 32; // chacha20poly1305 n_k
const POLY1305_TAG_SIZE: usize = 16;
pub const BHTTP_REQ_BYTES: usize =
ENCAPSULATED_MESSAGE_BYTES - (CHACHA20_POLY1305_NONCE_LEN + POLY1305_TAG_SIZE);
const V1_MAX_BUFFER_SIZE: usize = 65536;
pub(crate) const MAX_PAYLOAD_SIZE: usize = 7168;
Copy link
Copy Markdown
Contributor

@nothingmuch nothingmuch Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanGould has argued correctly that this can be closer to 8104 bytes, but there's a variable element of overhead in OHTTP requests relating to the request URI that makes this a bit tricky. i'm personally happy with this as the limit

Copy link
Copy Markdown
Collaborator Author

@zealsham zealsham Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nothingmuch i could not judge the status of this PR from the last comment


const V1_REJECT_RES_JSON: &str =
r#"{{"errorCode": "original-psbt-rejected ", "message": "Body is not a string"}}"#;
Expand Down Expand Up @@ -276,7 +276,7 @@ impl<D: Db> Service<D> {
.await
.map_err(|e| HandlerError::InternalServerError(e.into()))?
.to_bytes();
if req.len() > V1_MAX_BUFFER_SIZE {
if req.len() > MAX_PAYLOAD_SIZE {
return Err(HandlerError::PayloadTooLarge);
}
match self.db.post_v2_payload(&id, req.into()).await {
Expand Down Expand Up @@ -322,7 +322,7 @@ impl<D: Db> Service<D> {
.await
.map_err(|e| HandlerError::InternalServerError(e.into()))?
.to_bytes();
if req.len() > V1_MAX_BUFFER_SIZE {
if req.len() > MAX_PAYLOAD_SIZE {
return Err(HandlerError::PayloadTooLarge);
}

Expand Down Expand Up @@ -356,6 +356,9 @@ impl<D: Db> Service<D> {
Ok(bytes) => bytes.to_bytes(),
Err(_) => return Ok(bad_request_body_res),
};
if body_bytes.len() > MAX_PAYLOAD_SIZE {
return Err(HandlerError::PayloadTooLarge);
}
let body_str = match String::from_utf8(body_bytes.to_vec()) {
Ok(body_str) => body_str,
Err(_) => return Ok(bad_request_body_res),
Expand Down
Loading