Draft
Conversation
Contributor
|
Everything is looking good right now, just few things we might consider adding:
The taker/maker separation is clean and the scoring logic makes sense. |
Given an order book of UTXOs and a takers utxos which order book utxos we generate a list of cospends candidates.
To maker and taker
This action costs more if you have payment obligations. Or if you already have a input registered. In the future this can be smarter and internalize the cost of registering specific inputs with respect to the po's and privacy budget.
As its replaced by create cospend. And explicitly assign cost to accepting the co spend.
0783917 to
3fb4271
Compare
Collaborator
Author
|
went thru a messy rebase bc of #14 . will look thru history and clean it up again |
Mark po's as success if they are handled in the a cospend.
3fb4271 to
4a2ef9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All order book entries are considered atm. Takers will want to be selective and assign a payoff to each order book entry. At somepoint the cospend will be "good enough" (this will vary by wallet preference). Makers will register their input. The cost should consider their current payment obligation's deadlines.
In this current state the taker will prefer orderbook inputs that are closer in magnitude to its own inputs that it picked. I think we are missing two angles here:
other todos (maybe for future Prs):