You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
run_query() is documented as a one-shot helper that closes the connection, but it never actually closes the Connection, so repeated programmatic calls will leak QdrantClient instances. In src/qql/init.py the docstring says it “creates a Connection, runs one query, and closes the connection,” but the implementation at src/qql/init.py just returns Connection(...).run_query(query). I verified this with a small mock probe: run_query() called conn.run_query() once and conn.close() zero times. The new tests in tests/test_connection.py only assert delegation and also miss the close call entirely. Using with Connection(...) as conn: inside run_query() or explicitly calling close() after execution would fix both the behavior and the doc mismatch.
The README’s test-count documentation is inconsistent inside the same PR. The badge at README.md says 549 tests, and docs/reference.md was updated to 549, but the README still says “Expected: 500 tests passing” at README.md. I re-ran collection on the PR worktree and it reports 549 tests collected, so the README footer is stale.
I did not find other substantive code/test/doc gaps in this PR beyond those two. The new Connection surface itself is otherwise covered reasonably: 549 tests collect successfully on the PR snapshot, and tests/test_connection.py passes cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.