Skip to content

feat: react 17 support#399

Draft
andrewsantarin wants to merge 4 commits intopatw0929:masterfrom
andrewsantarin:feature/react-17-support
Draft

feat: react 17 support#399
andrewsantarin wants to merge 4 commits intopatw0929:masterfrom
andrewsantarin:feature/react-17-support

Conversation

@andrewsantarin
Copy link
Copy Markdown
Contributor

The React developers have released v17 since October 2020. With these changes, we would be able to support the latest React version.

Resolves #398

Description

  • Widened the supported range of react & react-dom peerDependencies.
  • Bumped devDependencies to support React v17.
  • Tweaked Enzyme jest tests to support React v17.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have used ESLint & Prettier to follow the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment thread config/jest/setup.js
import sinon from 'sinon'
import Enzyme from 'enzyme'
import Adapter from 'enzyme-adapter-react-16'
import Adapter from '@wojtekmaj/enzyme-adapter-react-17'
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enzymejs/enzyme#2429 (comment) indicates that the Enzyme maintainers won't be releasing support soon, so here's the drop-in replacement.

@andycansdale
Copy link
Copy Markdown

Any chance this could be merged? We are currently waiting on it. Thanks @andrewsantarin for doing the PR!

@geekdaniels
Copy link
Copy Markdown

Well done on this @andrewsantarin. Any luck with the merge @patw0929 ? Cheers

@lrocheWB
Copy link
Copy Markdown

@patw0929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm ERR! Could not resolve dependency: npm ERR! peer react@">15.4.2 <17.0.0" from react-intl-tel-input@8.2.0

4 participants